Enter key on forms for deploy image and process template #1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
force-pushed
the
enter-key-submit
branch
from
051e9e8 to
145e200
Compare
|
LGTM but probably worth a comment saying that |
jwforres
force-pushed
the
enter-key-submit
branch
from
145e200 to
78e53ab
Compare
jwforres
force-pushed
the
enter-key-submit
branch
from
78e53ab to
49ed85f
Compare
|
@spadgett added the comment to both templates |
spadgett
approved these changes
Jun 15, 2017
|
[merge][severity: bug] |
|
Evaluated for origin web console merge up to 49ed85f |
|
[Test]ing while waiting on the merge queue |
|
Evaluated for origin web console test up to 49ed85f |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1542/) (Base Commit: 6e95ce2) (PR Branch Commit: 49ed85f) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1548/) (Base Commit: 039d765) (PR Branch Commit: 49ed85f) (Extended Tests: bug) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1703