-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Add test watching for overloaded network via etcd logging #30013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Outcome from OCPBUGS-56921, lets see how common this is in the wild
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: f876d6a
|
Output: msg, | ||
}, | ||
} | ||
return []*junitapi.JUnitTestCase{failure} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checking we don't want to flake and monitor. Looks like we are good on presubmits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
etcdOverloadedNetworkLimit = 10000
is rather high so we are likely good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I thought about it as well and came to same conclusion, if this is going on, I'd like to know asap. 44 passes on the pr so far though so hopefully very rare.
/lgtm |
/hold I mis-pushed another test I was working on that is nowhere near ready this morning, didn't realize I hadn't switched to a new branch. Sorry about that. Will force update to just the etcd overload test. |
f876d6a
to
c38bda8
Compare
/test unit |
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, neisw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Job Failure Risk Analysis for sha: c38bda8
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: c38bda8
New tests seen in this PR at sha: c38bda8
|
Outcome from OCPBUGS-56921, lets see how common this is in the wild