OCPEDGE-1969: add recovery tests for TNA

[Neilhamza]

add recovery tests for TNA
update common.go
arbiter e2e run

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-1969 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

add recovery tests for TNA
update common.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-trt]

Job Failure Risk Analysis for sha: 1bac549

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-azure-ovn-etcd-scaling	Medium [bz-openshift-apiserver] clusteroperator/openshift-apiserver should not change condition/Available This test has passed 97.19% of 4444 runs on release 4.20 [Overall] in the last week. Open Bugs openshift-apiserver ClusterOperator should not blip Available=False on brief missing HTTP content-type
pull-ci-openshift-origin-main-e2e-gcp-disruptive	IncompleteTests Tests for this run (107) are below the historical average (144): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-techpreview-serial-2of2	Medium [sig-arch] events should not repeat pathologically for ns/openshift-network-diagnostics Potential external regression detected for High Risk Test analysis --- [sig-arch] events should not repeat pathologically for ns/openshift-multus Potential external regression detected for High Risk Test analysis

[dhensel-rh]

@Neilhamza Are you splitting out the code in common.go to make it reusable by Arbiter only ?

[Neilhamza]

@Neilhamza Are you splitting out the code in common.go to make it reusable by Arbiter only ?

i have splitted the code because it can be reused by any test not just arbiter

[dhensel-rh]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dhensel-rh, Neilhamza
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eggfoobar]

/test e2e-metal-ovn-two-node-arbiter

[openshift-ci-robot]

@Neilhamza: This pull request references OCPEDGE-1969 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set.

In response to this:

add recovery tests for TNA
update common.go
arbiter e2e run

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

@Neilhamza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling	1bac549	link	false	/test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6	1bac549	link	false	/test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/e2e-azure-ovn-upgrade	1bac549	link	false	/test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn-etcd-scaling	1bac549	link	false	/test e2e-azure-ovn-etcd-scaling
ci/prow/e2e-aws-ovn-etcd-scaling	1bac549	link	false	/test e2e-aws-ovn-etcd-scaling
ci/prow/e2e-gcp-fips-serial-2of2	1bac549	link	false	/test e2e-gcp-fips-serial-2of2
ci/prow/e2e-gcp-fips-serial-1of2	1bac549	link	false	/test e2e-gcp-fips-serial-1of2
ci/prow/e2e-gcp-disruptive	1bac549	link	false	/test e2e-gcp-disruptive
ci/prow/e2e-openstack-serial	1bac549	link	false	/test e2e-openstack-serial
ci/prow/e2e-vsphere-ovn-etcd-scaling	1bac549	link	false	/test e2e-vsphere-ovn-etcd-scaling
ci/prow/e2e-metal-ovn-two-node-arbiter	1bac549	link	false	/test e2e-metal-ovn-two-node-arbiter
ci/prow/e2e-gcp-ovn-techpreview	9881db2	link	false	/test e2e-gcp-ovn-techpreview
ci/prow/e2e-aws-ovn-single-node-upgrade	9881db2	link	false	/test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-dualstack-local-gateway	9881db2	link	false	/test e2e-metal-ipi-ovn-dualstack-local-gateway
ci/prow/e2e-vsphere-ovn	9881db2	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-gcp-ovn	9881db2	link	true	/test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-serial-2of2	9881db2	link	false	/test e2e-metal-ipi-serial-2of2
ci/prow/e2e-aws-ovn-fips	9881db2	link	true	/test e2e-aws-ovn-fips
ci/prow/e2e-metal-ipi-ovn-kube-apiserver-rollout	9881db2	link	false	/test e2e-metal-ipi-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-serial-1of2	9881db2	link	true	/test e2e-aws-ovn-serial-1of2
ci/prow/e2e-metal-ipi-ovn	9881db2	link	false	/test e2e-metal-ipi-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6	9881db2	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-1of2	9881db2	link	false	/test e2e-metal-ipi-serial-ovn-ipv6-1of2
ci/prow/e2e-azure	9881db2	link	false	/test e2e-azure
ci/prow/e2e-metal-ipi-ovn-dualstack	9881db2	link	false	/test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-serial-1of2	9881db2	link	false	/test e2e-metal-ipi-serial-1of2
ci/prow/e2e-metal-ipi-serial-ovn-ipv6-2of2	9881db2	link	false	/test e2e-metal-ipi-serial-ovn-ipv6-2of2
ci/prow/e2e-hypershift-conformance	9881db2	link	false	/test e2e-hypershift-conformance
ci/prow/e2e-gcp-ovn-techpreview-serial-2of2	9881db2	link	false	/test e2e-gcp-ovn-techpreview-serial-2of2
ci/prow/e2e-metal-ipi-virtualmedia	9881db2	link	false	/test e2e-metal-ipi-virtualmedia
ci/prow/e2e-aws-proxy	9881db2	link	false	/test e2e-aws-proxy
ci/prow/e2e-aws-ovn-edge-zones	9881db2	link	true	/test e2e-aws-ovn-edge-zones
ci/prow/e2e-openstack-ovn	9881db2	link	false	/test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial	9881db2	link	false	/test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn	9881db2	link	false	/test e2e-aws-ovn
ci/prow/e2e-aws-disruptive	9881db2	link	false	/test e2e-aws-disruptive
ci/prow/e2e-agnostic-ovn-cmd	9881db2	link	false	/test e2e-agnostic-ovn-cmd
ci/prow/e2e-vsphere-ovn-upi	9881db2	link	true	/test e2e-vsphere-ovn-upi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-trt]

Job Failure Risk Analysis for sha: 9881db2

Job Name	Failure Risk
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn	IncompleteTests Tests for this run (102) are below the historical average (2511): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack	IncompleteTests Tests for this run (102) are below the historical average (2471): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-dualstack-local-gateway	IncompleteTests Tests for this run (102) are below the historical average (2504): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6	IncompleteTests Tests for this run (102) are below the historical average (2607): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-kube-apiserver-rollout	IncompleteTests Tests for this run (102) are below the historical average (1288): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-virtualmedia	IncompleteTests Tests for this run (102) are below the historical average (2456): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-openstack-ovn	IncompleteTests Tests for this run (102) are below the historical average (2861): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)