Skip to content

Conversation

Ajpantuso
Copy link

@Ajpantuso Ajpantuso commented Sep 5, 2025

Summary

Adds hidden options to set both Master and Infra node types for Classic clusters to enable testing of regions where [m|r]5 instances are not available and provisioning would normally fail.

Closes SLSRE-371

Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ajpantuso
Once this PR has been reviewed and has the lgtm label, please assign xueli181114 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Ajpantuso Ajpantuso force-pushed the apantuso/SLSRE-371 branch 2 times, most recently from 2920888 to 61ad0ec Compare September 5, 2025 14:37
@Ajpantuso
Copy link
Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Sep 5, 2025

@Ajpantuso: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.77%. Comparing base (ec0065b) to head (18671f7).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
pkg/ocm/clusters.go 0.00% 4 Missing ⚠️
cmd/create/cluster/cmd.go 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3007      +/-   ##
==========================================
+ Coverage   27.74%   27.77%   +0.02%     
==========================================
  Files         315      315              
  Lines       34796    34816      +20     
==========================================
+ Hits         9655     9669      +14     
- Misses      24489    24495       +6     
  Partials      652      652              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant