tests/osc-test-fbc-integration: new parameters and misc updates #1469
Conversation
The expected operator version parameter is used by QE tests check the operator catalog is released with the right version. As we are in the 1.11.1 release cycle, bumped it. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
The extra newline in CATALOG_IMAGE is preventing the ENVS variable from being parsed correctly. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
By default the prow job succeed even when tests failed. The only situation it fails is when there is an CI infra problem. We don't that behavior on jobs triggered by konflux, otherwise we will be needed to inspect all results. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
Use latest and greatest version of konflux-tasks that provides improvements such as retrying job creation in case of fail. Signed-off-by: Wainer dos Santos Moschetta <[email protected]>
|
/lgtm |
|
/approve |
littlejawa
left a comment
littlejawa
left a comment
There was a problem hiding this comment.
/lgtm
Thanks @wainersm !
|
/retest |
|
/retest The latest failure on CI seems to be in Prow infra. |
|
/retest |
|
@wainersm: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
tests/osc-test-fbc-integration.yaml
Outdated
| value: downstream-candidate | ||
| - name: ENVS | ||
| value: "CATALOG_SOURCE_IMAGE=$(tasks.get-catalog-image.results.CATALOG_IMAGE)" | ||
| value: "CATALOG_SOURCE_IMAGE=$(tasks.get-catalog-image.results.CATALOG_IMAGE),EXPECTED_OPERATOR_VERSION=1.11.1" |
There was a problem hiding this comment.
Should this bump occur at the same time we bump versions with the ## OSC_VERSION tag as documented at https://github.com/openshift/sandboxed-containers-operator/blob/devel/docs/DEVELOPMENT.md#updating-versions ? Or should this be only bumped after the bundle was pushed and the test-catalog udpated accordingly as in f70661f ?
There was a problem hiding this comment.
Hi @gkurz !
This pipeline aims to test OSC on updates of the test-catalog, so it should be only bumped alongside the commit f70661f
I want to document it somewhere or have the bump done automatically, that's why I asked you and @littlejawa on slack. IIUC test-catalog version is bumped manually so I want to have a small section in fbc/README.md that explains how test-catalog version (and this pipeline) is updated. Makes sense?
6 participants
The current osc-test-fbc-integration pipeline in Konflux which runs to test the test-fbc catalog have a broken test because it expects the old operator version of 1.11.0. I could have it fixed in Prow side, but I preferred to add a new
EXPECTED_OPERATOR_VERSIONparameter to the pipeline so we can bump the version at same time test-fbc version is raised.In order to have
EXPECTED_OPERATOR_VERSIONtaking effect I had to fix a issue (that's the commit 3c66305).While in here, because testing these changes is time-consuming, I added two more changes:
FORCE_SUCCESS_EXIT=noparameter to force the job report fail to any kind of error (CI infra or tests failures)