Skip to content

Drop the peerpod machine configs #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gkurz merged 3 commits into from
Oct 27, 2025
Merged

Drop the peerpod machine configs #941

gkurz merged 3 commits into from
Oct 27, 2025

Conversation

@gkurz
Copy link
Member

@gkurz gkurz commented Sep 1, 2025 •
edited
Loading

These files are now shipped by the RPM.

https://issues.redhat.com/browse/KATA-3969

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@beraldoleal beraldoleal mentioned this pull request Sep 2, 2025
Merged
@gkurz gkurz force-pushed the drop-peerpods-conf branch from 078f34f to fafb3f1 Compare October 13, 2025 14:03
@gkurz gkurz marked this pull request as ready for review October 14, 2025 06:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025
@gkurz
Copy link
Member Author

gkurz commented Oct 14, 2025

/ok-to-test

@openshift-ci openshift-ci bot requested review from c3d and wainersm October 14, 2025 06:00
@openshift-ci openshift-ci bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 14, 2025
@gkurz
Copy link
Member Author

gkurz commented Oct 14, 2025

This change breaks peer pods with the current RPM. Let's wait for an official build of the kata 3.21 RPM to be available.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 14, 2025
gkurz added 3 commits October 22, 2025 18:45
@gkurz
Drop DEFAULT_PEER_PODS
452b548 
Leftover from 4b01583 ("Remove peerpods config management.").

Signed-off-by: Greg Kurz <[email protected]>
@gkurz
Drop peerpodConfigCrdName
a912a59 
This CRD was dropped quite some time ago. Its name is
only meaningful for the migration code. Opencode it
at its only user there.

Signed-off-by: Greg Kurz <[email protected]>
@gkurz
Drop the peer-pods machine configs
1e81c99 
These files are now shipped by the RPM.

Signed-off-by: Greg Kurz <[email protected]>
@gkurz gkurz force-pushed the drop-peerpods-conf branch from fafb3f1 to 1e81c99 Compare October 22, 2025 16:45
@openshift-ci
Copy link

openshift-ci bot commented Oct 22, 2025

@gkurz: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bpradipt
bpradipt approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @gkurz

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2025
@gkurz
Copy link
Member Author

gkurz commented Oct 23, 2025

/retest

@gkurz
Copy link
Member Author

gkurz commented Oct 27, 2025

/unhold

It is better to drop these now because the manual installation of a kata 3.21 RPMs end up conflicting with the MCO view of the OS and degrades the node.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 27, 2025
@gkurz gkurz merged commit 1af0aa7 into openshift:devel Oct 27, 2025
6 of 7 checks passed
@gkurz gkurz deleted the drop-peerpods-conf branch October 27, 2025 09:48
@Pacho20 Pacho20 mentioned this pull request Nov 27, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bpradipt bpradipt bpradipt approved these changes

@c3d c3d Awaiting requested review from c3d

@wainersm wainersm Awaiting requested review from wainersm

Assignees

@bpradipt bpradipt

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gkurz @bpradipt