jsonnet/telemeter/server: move whitelist out of secret #131
Conversation
This commit removes the whitelist from the Telemeter server secret and places it instead in a series of command line `--whitelist` flags. This is helpful for several reasons: 1. as the whitelist is no longer in a secret it no longer has to be handled manually, preventing potential human error when the whitelist changes; and 2. when the whitelist changes, the DaemonSet spec will also change so the new configuration will automatically be rolled out without needing to manually kick pods.
openshift-ci-robot
added
the
size/M
openshift-ci-robot
added
the
approved
| local secretVolume = volume.fromSecret(secretVolumeName, secretName); | ||
|
|
||
| local whitelist = std.map( | ||
| function(rule) "--whitelist='%s'" % std.strReplace(rule, 'ALERTS', 'alerts'), |
There was a problem hiding this comment.
does it make sense to do a std.asciiLower(str) here instead?
There was a problem hiding this comment.
no it does not make sense here; there may very well be metric names or labels in the whitelist that we do not want completely lowercased. The only one we care about today is the ALERTS metric name.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s-urbaniak, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
fixes #121 |
This commit removes the whitelist from the Telemeter server secret and
places it instead in a series of command line
--whitelistflags. Thisis helpful for several reasons:
handled manually, preventing potential human error when the whitelist
changes; and
the new configuration will automatically be rolled out without needing
to manually kick pods.
cc @s-urbaniak @jfchevrette