-
Notifications
You must be signed in to change notification settings - Fork 15
OCPBUGS-52945: Update Go version in go.mod to 1.22.0 #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-52945: Update Go version in go.mod to 1.22.0 #159
Conversation
This commit modifies the go.mod file to explicitly use go version 1.22.0. This is done in order to avoid konflux build issues when using hermetic builds related to failure finding the toolchain. Signed-off-by: Daniel Mellado <[email protected]>
This commit enables hermetic builds for Thanos. It also modifies its Dockerfile to skip using promu and removes the rpm fetcher configuration given that COO is in the public cluster and can't access internal RH network. This is dependent on openshift/thanos#159. Otherwise this would fail to find the golang toolchain. Signed-off-by: Daniel Mellado <[email protected]>
A @saswatamcode wdyt? |
We can merge this to unblock the konflux build but we'll need the bug chain to get this merged. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielmellado, jan--f The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@danielmellado: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
I was hoping to only have this in 4.18 and have the Konflux tooling patch this on the fly, had a few conversation but not sure about the timing, Will create a OCPBUGS and make this the backport, thanks! |
@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
2 similar comments
/jira refresh |
/jira refresh |
This commit enables hermetic builds for Thanos. It also modifies its Dockerfile to skip using promu and removes the rpm fetcher configuration given that COO is in the public cluster and can't access internal RH network. This is dependent on openshift/thanos#159. Otherwise this would fail to find the golang toolchain. Signed-off-by: Daniel Mellado <[email protected]>
/jira refresh |
@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label cherry-pick-approved |
/label backport-risk-assessed |
f1599f6
into
openshift:release-4.18
@danielmellado: Jira Issue OCPBUGS-52945: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-52945 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: thanos |
Fix included in accepted release 4.18.0-0.nightly-2025-04-01-173525 |
This commit modifies the go.mod file to explicitly use go version
1.22.0. This is done in order to avoid konflux build issues when using
hermetic builds related to failure finding the toolchain.