Skip to content

OCPBUGS-52945: Update Go version in go.mod to 1.22.0 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

danielmellado
Copy link

This commit modifies the go.mod file to explicitly use go version
1.22.0. This is done in order to avoid konflux build issues when using
hermetic builds related to failure finding the toolchain.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

This commit modifies the go.mod file to explicitly use go version
1.22.0. This is done in order to avoid konflux build issues when using
hermetic builds related to failure finding the toolchain.

Signed-off-by: Daniel Mellado <[email protected]>
@openshift-ci openshift-ci bot requested review from jan--f and rexagod March 10, 2025 20:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2025
danielmellado added a commit to danielmellado/konflux-coo that referenced this pull request Mar 10, 2025
This commit enables hermetic builds for Thanos. It also modifies its
Dockerfile to skip using promu and removes the rpm fetcher configuration
given that COO is in the public cluster and can't access internal RH
network.

This is dependent on openshift/thanos#159.
Otherwise this would fail to find the golang toolchain.

Signed-off-by: Daniel Mellado <[email protected]>
@jan--f
Copy link

jan--f commented Mar 10, 2025

A toolchain directive might be better here. This will be required in future versions anyway iiuc and might be upstreamable. See golang/go#62278 (comment)

@saswatamcode wdyt?

@jan--f
Copy link

jan--f commented Mar 10, 2025

We can merge this to unblock the konflux build but we'll need the bug chain to get this merged.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2025
Copy link

openshift-ci bot commented Mar 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, jan--f

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,jan--f]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 11, 2025

@danielmellado: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@danielmellado
Copy link
Author

We can merge this to unblock the konflux build but we'll need the bug chain to get this merged. /lgtm

I was hoping to only have this in 4.18 and have the Konflux tooling patch this on the fly, had a few conversation but not sure about the timing, Will create a OCPBUGS and make this the backport, thanks!

@danielmellado danielmellado changed the title Update Go version in go.mod to 1.22.0 OCPBUGS-52945: Update Go version in go.mod to 1.22.0 Mar 11, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 11, 2025
@openshift-ci-robot
Copy link

@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:

  • expected the bug to target either version "4.18." or "openshift-4.18.", but it targets "4.19" instead
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-52945 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This commit modifies the go.mod file to explicitly use go version
1.22.0. This is done in order to avoid konflux build issues when using
hermetic builds related to failure finding the toolchain.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielmellado
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-52945 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielmellado
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is invalid:

  • expected Jira Issue OCPBUGS-52945 to depend on a bug targeting a version in 4.19.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@danielmellado
Copy link
Author

/jira refresh

2 similar comments
@danielmellado
Copy link
Author

/jira refresh

@danielmellado
Copy link
Author

/jira refresh

danielmellado added a commit to danielmellado/konflux-coo that referenced this pull request Mar 11, 2025
This commit enables hermetic builds for Thanos. It also modifies its
Dockerfile to skip using promu and removes the rpm fetcher configuration
given that COO is in the public cluster and can't access internal RH
network.

This is dependent on openshift/thanos#159.
Otherwise this would fail to find the golang toolchain.

Signed-off-by: Daniel Mellado <[email protected]>
@danielmellado
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 12, 2025
@openshift-ci-robot
Copy link

@danielmellado: This pull request references Jira Issue OCPBUGS-52945, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-52962 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-52962 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 12, 2025
@openshift-ci openshift-ci bot requested a review from juzhao March 12, 2025 07:11
@Tai-RedHat
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 12, 2025
@jan--f
Copy link

jan--f commented Mar 13, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 13, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit f1599f6 into openshift:release-4.18 Mar 13, 2025
10 checks passed
@openshift-ci-robot
Copy link

@danielmellado: Jira Issue OCPBUGS-52945: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-52945 has been moved to the MODIFIED state.

In response to this:

This commit modifies the go.mod file to explicitly use go version
1.22.0. This is done in order to avoid konflux build issues when using
hermetic builds related to failure finding the toolchain.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: thanos
This PR has been included in build ose-thanos-container-v4.18.0-202503131105.p0.gf1599f6.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.18.0-0.nightly-2025-04-01-173525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants