Merge Opensim 4.5.2 fix to rpath issues for moco dependencies #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge section label in CHANGELOG.md
avoid upgrading cmake
Undo cmake change, just pin cmake in ci file instead
add MD flag to cxx on windows
* Use correct Metis library name when setting rpath on Linux * Fix cmake to install ipopt and deps on unix --------- Co-authored-by: Nick Bianco <[email protected]>
* Update OpenSimMocoInstallMacDependencyLibraries.cmake.in * Update continuous_integration.yml * Rpath fixes for mac * Update OpenSimMocoInstallMacDependencyLibraries.cmake.in fix typo in CMake variable * More RPATH gymnatics --------- Co-authored-by: Ayman <[email protected]>
remove debugging lines to reduce clutter
There was a problem hiding this comment.
Pull Request Overview
This PR addresses rpath issues for Moco dependencies by updating CMake install scripts on both macOS and Linux, adjusting the dependency-copy logic, and cleaning up the changelog.
- Adds and refines macOS rpath adjustments for IPOPT and its dependencies
- Replaces
coinmetis.so.1withmetis.soin Linux rpath handling - Broadens the
OPENSIM_COPY_DEPENDENCIEScondition inCMakeLists.txtto all platforms - Removes an extraneous blank line in
CHANGELOG.md
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmake/OpenSimMocoInstallMacDependencyLibraries.cmake.in | Inserted deletes/adds for IPOPT & coinmumps rpaths and added gfortran fixup |
| cmake/OpenSimMocoInstallLinuxDependencyLibraries.cmake.in | Swapped out coinmetis.so.1 operations for metis.so |
| CMakeLists.txt | Removed the AND LINUX restriction on OPENSIM_COPY_DEPENDENCIES |
| CHANGELOG.md | Deleted a stray blank line before the v4.5.2 header |
Comments suppressed due to low confidence (2)
CMakeLists.txt:862
- The Linux-specific code that copies gfortran libraries now runs on all platforms; this may break non-Linux builds. Consider reintroducing an OS check (e.g.,
AND LINUX) or moving this block under a Linux-only guard.
elseif(OPENSIM_COPY_DEPENDENCIES)
cmake/OpenSimMocoInstallLinuxDependencyLibraries.cmake.in:38
- Most distros install a versioned libmetis like
libmetis.so.5. Verify thatmetis.soexists on target systems or consider using a glob pattern to locate the correct versioned filename.
install_name_tool_print_rpath(metis.so)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #0
Brief summary of changes
Testing I've completed
Looking for feedback on...
CHANGELOG.md (choose one)
This change is