Skip to content

Allow to specify tmp path #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
SolidTux opened this issue Sep 3, 2020 · 2 comments
Closed

Allow to specify tmp path #17

SolidTux opened this issue Sep 3, 2020 · 2 comments

Comments

@SolidTux
Copy link

SolidTux commented Sep 3, 2020

It's probably not always a good idea to leave a temporary file in the working directory. Is there a reason why this is not in the tmp folder by default (std::env::temp_dir for example)?
@jonhoo
Copy link
Collaborator

jonhoo commented Sep 3, 2020 •
edited
Loading

The temporary file should be automatically deleted when the connection is terminated. I had it be created in the current directory to make it easier to debug remote sessions by manually sshing in with the same connection. I'd be totally open to making this behavior configurable through the builder though (see #16).

@jonhoo jonhoo mentioned this issue Sep 3, 2020
Merged
@jonhoo
Copy link
Collaborator

jonhoo commented Sep 4, 2020

Fixed by #16

@jonhoo jonhoo closed this as completed Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonhoo @SolidTux