Add an option to place the temporary path for ControlDirectory in a user-set location. #16
Conversation
…ser-set location.
Codecov Report
|
|
This looks great, thank you! It'd also fix #17 🎉 I'd like to see a test, which I think should be pretty easy. Just copy the |
|
@jonhoo Thanks! Think I addressed your comments, let me know if that covers it. |
|
Thanks! Let me take a look |
tests/openssh.rs
Outdated
| #[tokio::test] | ||
| #[cfg_attr(not(ci), ignore)] | ||
| async fn control_dir() { | ||
| let session = SessionBuilder::default().control_directory(&path()).connect(&addr()).await.unwrap(); |
There was a problem hiding this comment.
I think you need to run rustfmt on this file — that's what CI is complaining about :)
There was a problem hiding this comment.
Not sure it's related to my changes -- I'm seeing lots of this error in that file:
error[E0670]: `async fn` is not permitted in the 2015 edition
--> /home/lincolnb/rust/openssh-rs/tests/openssh.rs:14:1
|
14 | async fn it_connects() {
| ^^^^^ to use `async fn`, switch to Rust 2018
|
= help: set `edition = "2018"` in `Cargo.toml`
= note: for more on editions, read https://doc.rust-lang.org/edition-guide
There was a problem hiding this comment.
That's weird... Do you have a very old version of Rust installed/
There was a problem hiding this comment.
No, turns out you have to specify --edition 2018 on the command line!
There was a problem hiding this comment.
Ohhh, for rustfmt. Yeah, you're running into rust-lang/rustfmt#4074, which is awkward. You can also add a file in the current directory called rustfmt.toml that contains edition = "2018". It's.... not great.
|
You may also want to merge with master to get the CI fixes I just pushed :) |
|
Excellent, thanks for sticking with it! Published in 0.6.3 🎉 |
|
Thanks for merging! |
I'd like to be able to put the temporary directory where the control socket is created is a custom location.
This patch enables that by adding the
.control_directory()function to the SessionBuilder.Tried to match code style best I could, but please give suggestions for naming/style consistency as appropriate.
I tested manually, with and without the
control_directoryoption. Didn't add anything totests/openssh.rsas I didn't see anything similar forkeyfile, which was my guide for this change.If tests are requested, please give some ideas about how this should best be done -- relatively new to Rust so I may need a push in the right direction :)