Skip to content

Add bootc image reference #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bshephar
Copy link
Contributor

@bshephar bshephar commented Feb 27, 2025

To support image mode RHEL deployments, this change adds the reference to the bootc container image.

Jira: https://issues.redhat.com/browse/OSPRH-14326

@openshift-ci openshift-ci bot requested review from fultonj and rabi February 27, 2025 04:29
Copy link
Contributor

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bshephar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2a7f196aab34a5da9b3d0e5840c74b9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 20s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 34m 24s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 33m 55s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 38m 31s

@bshephar
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

1 similar comment
@bshephar
Copy link
Contributor Author

/test openstack-operator-build-deploy-kuttl

@bshephar
Copy link
Contributor Author

recheck FAILURE

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/83b1f4bb3c79438e81bcbac3ef97c6dd

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 23m 34s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 52s
cifmw-crc-podified-edpm-baremetal FAILURE in 1h 25m 58s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 07m 45s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 43m 11s

@bshephar
Copy link
Contributor Author

Unrelated failures:

❯ curl -s "https://logserver.rdoproject.org/21/1321/e320a18f35f52482ca40de94b9c0b121ec5619e2/github-check/cifmw-crc-podified-edpm-baremetal/54b00d4/ci-framework-data/logs/openstack-k8s-operators-openstack-must-gather/namespaces/openstack/pods/repo-setup-edpm-deployment-ipam-openstack-edpm-ipam-prjfm/logs/repo-setup-edpm-deployment-ipam-openstack-edpm-ipam.log" | tail -n10
fatal: [edpm-compute-0]: FAILED! => {"changed": true, "cmd": "set -euxo pipefail\npushd /var/tmp\ncurl -sL https://github.com/openstack-k8s-operators/repo-setup/archive/refs/heads/main.tar.gz | tar -xz\npushd repo-setup-main\npython3 -m venv ./venv\nPBR_VERSION=0.0.0 ./venv/bin/pip install ./\n# This is required for FIPS enabled until trunk.rdoproject.org\n# is not being served from a centos7 host, tracked by\n# https://issues.redhat.com/browse/RHOSZUUL-1517\nupdate-crypto-policies --set FIPS:NO-ENFORCE-EMS\n./venv/bin/repo-setup current-podified -b antelope\npopd\nsed -i '/AppStream/a exclude=\"libvirt*10.10.0-4*,qemu*9.1.0-9*\"' /etc/yum.repos.d/repo-setup-centos-appstream.repo\nsed -i '/AppStream/a exclude=\"libvirt*10.10.0-4*,qemu*9.1.0-9*\"' /etc/yum.repos.d/centos.repo || true\nrm -rf repo-setup-main\n", "delta": "0:00:20.046624", "end": "2025-02-27 17:57:59.442203", "msg": "non-zero return code", "rc": 2, "start": "2025-02-27 17:57:39.395579", "stderr": "+ pushd /var/tmp\n+ tar -xz\n+ curl -sL https://github.com/openstack-k8s-operators/repo-setup/archive/refs/heads/main.tar.gz\n\ngzip: stdin: unexpected end of file\ntar: Child returned status 1\ntar: Error is not recoverable: exiting now", "stderr_lines": ["+ pushd /var/tmp", "+ tar -xz", "+ curl -sL https://github.com/openstack-k8s-operators/repo-setup/archive/refs/heads/main.tar.gz", "", "gzip: stdin: unexpected end of file", "tar: Child returned status 1", "tar: Error is not recoverable: exiting now"], "stdout": "/var/tmp /home/cloud-admin", "stdout_lines": ["/var/tmp /home/cloud-admin"]}

PLAY RECAP *********************************************************************
edpm-compute-0             : ok=1    changed=0    unreachable=0    failed=1    skipped=0    rescued=0    ignored=0

@bshephar bshephar force-pushed the dataplane-bootc-image branch from e320a18 to c016d45 Compare March 2, 2025 23:25
@bshephar bshephar force-pushed the dataplane-bootc-image branch 2 times, most recently from 52b68f7 to c751d7d Compare March 3, 2025 07:17
@fmount
Copy link
Contributor

fmount commented Mar 3, 2025

+1 from me but adding someone from the core team to approve

@fmount fmount requested review from stuggi, abays and dprince March 3, 2025 09:05
@abays
Copy link
Contributor

abays commented Mar 3, 2025

Does this by any chance need a change to pkg/dataplane/util/version.go as well? Just checking because I was reviewing something similar this weekend and, in that case, a change was needed in the file [1].

[1] https://github.com/openstack-k8s-operators/openstack-operator/pull/1319/files#diff-80f6225dc117813e2cfef98d6356561b01b979f012f2bdc7ff98113f232a2da6

@stuggi
Copy link
Contributor

stuggi commented Mar 3, 2025

looks good to me, but I'd say lets wait for it to land after the FR2 branching

Copy link
Contributor

@slagle slagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might want to hold on this until we have a targeted release (FR3 perhaps), or at least a plan for how this would be set downstream.

@bshephar
Copy link
Contributor Author

bshephar commented Mar 3, 2025

/test openstack-operator-build-deploy-kuttl

@bshephar bshephar force-pushed the dataplane-bootc-image branch from c751d7d to edf7cc5 Compare March 3, 2025 23:31
@bshephar
Copy link
Contributor Author

bshephar commented Mar 3, 2025

Does this by any chance need a change to pkg/dataplane/util/version.go as well? Just checking because I was reviewing something similar this weekend and, in that case, a change was needed in the file [1].

[1] https://github.com/openstack-k8s-operators/openstack-operator/pull/1319/files#diff-80f6225dc117813e2cfef98d6356561b01b979f012f2bdc7ff98113f232a2da6

Indeed, thanks. I've updated that reference now.

@bshephar
Copy link
Contributor Author

bshephar commented Mar 3, 2025

/hold

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8a7e81f5cf344053aa42e0e8ec46bc3b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 11s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 01s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 24m 21s
adoption-standalone-to-crc-ceph-provider RETRY_LIMIT in 15m 03s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 41s

@bshephar bshephar force-pushed the dataplane-bootc-image branch from edf7cc5 to 702b910 Compare March 5, 2025 22:39
@bshephar bshephar force-pushed the dataplane-bootc-image branch from 702b910 to d95f603 Compare April 3, 2025 04:24
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f5d13c3eea9f4f5189e97bd00d1af6cb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 57m 09s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 15m 17s
cifmw-crc-podified-edpm-baremetal FAILURE in 59m 03s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 41m 32s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 35m 42s
openstack-operator-kuttl FAILURE in 29m 48s (non-voting)

@bshephar bshephar force-pushed the dataplane-bootc-image branch from d95f603 to efbeaf9 Compare April 11, 2025 22:44
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/024472b06ee04063a8fb671099f882a9

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 37m 49s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 26s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 22m 10s
openstack-operator-tempest-multinode FAILURE in 1h 28m 24s
openstack-operator-kuttl FAILURE in 26m 53s (non-voting)

@bshephar bshephar force-pushed the dataplane-bootc-image branch from efbeaf9 to ca09912 Compare April 14, 2025 02:32
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e57172d5fc37470e9c97b47ea2dfb6ea

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 33m 32s
podified-multinode-edpm-deployment-crc FAILURE in 1h 34m 47s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 34s
✔️ adoption-standalone-to-crc-ceph-provider SUCCESS in 3h 16m 02s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 25m 24s
openstack-operator-kuttl FAILURE in 24m 45s (non-voting)

@bshephar bshephar force-pushed the dataplane-bootc-image branch from ca09912 to 4fc43f3 Compare May 6, 2025 04:26
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b2f3fda118804bd79cfdd122a8eef28b

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 53m 35s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 50s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 35m 21s
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 28m 13s
openstack-operator-kuttl FAILURE in 26m 27s (non-voting)

To support image mode RHEL deployments, this change adds the reference
to the bootc container image.

Jira: https://issues.redhat.com/browse/OSPRH-14326
Signed-off-by: Brendan Shephard <[email protected]>
@bshephar bshephar force-pushed the dataplane-bootc-image branch from 4fc43f3 to 0aebc58 Compare May 6, 2025 06:22
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/db6b5fd20f934ddbafdf79b278765451

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 51m 46s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 40s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 27m 59s
adoption-standalone-to-crc-ceph-provider FAILURE in 1h 37m 34s
openstack-operator-tempest-multinode RETRY_LIMIT in 12m 41s
openstack-operator-kuttl FAILURE in 25m 59s (non-voting)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants