Skip to content

Enable prometheus admin API to allow us to delete old injected metrics #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morenod
Copy link

@morenod morenod commented Jul 7, 2025

We need to delete injected metrics between tests to avoid overlapping between tests

This can be done by enabling this API and executing requests like [1]

There is no option (by now) to do it on the openstackcontrolplane object, so now we have to patch prometheus after it is created, we will manage to add an option to include this API on the controlplane object [2]

[1] https://metric-storage-prometheus.openstack.svc:9090/api/v1/admin/tsdb/delete_series?match[]={job="promtool"}
[2] https://github.com/rhobs/observability-operator/blob/d0e25a27bde3ba2ca6c39a6fb259e93c8ae8cc99/pkg/apis/monitoring/v1alpha1/types.go#L177

Copy link

openshift-ci bot commented Jul 7, 2025

Hi @morenod. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9030c4b7e3e84b1d8e2014cb8e27bcac

✔️ openstack-meta-content-provider-master SUCCESS in 1h 44m 59s
watcher-operator-validation-master FAILURE in 1h 02m 16s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 1h 38m 30s
watcher-operator-validation-epoxy FAILURE in 1h 01m 57s
watcher-operator-validation-epoxy-ocp4-16 FAILURE in 1h 07m 52s
✔️ noop SUCCESS in 0s
watcher-operator-kuttl RETRY_LIMIT in 25m 11s

@morenod morenod force-pushed the enable_prometheus_admin_api branch from dee82ef to 4a85dc1 Compare July 7, 2025 15:09
@morenod
Copy link
Author

morenod commented Jul 8, 2025

recheck

@morenod morenod changed the title [WIP] Enable prometheus admin API to allow us to delete old injected metrics Enable prometheus admin API to allow us to delete old injected metrics Jul 9, 2025
@morenod morenod force-pushed the enable_prometheus_admin_api branch from dd46803 to a18a38c Compare July 9, 2025 08:02
@morenod
Copy link
Author

morenod commented Jul 9, 2025

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d4426cb48d8546afadb77dbc9fc7f913

Warning:
Dependency cycle detected and project openstack/watcher-tempest-plugin doesn't allow circular dependencies

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d20fd5d008684530bfbfc572a19caf65

Warning:
Dependency cycle detected and project openstack/watcher-tempest-plugin doesn't allow circular dependencies

@morenod
Copy link
Author

morenod commented Jul 9, 2025

recheck

@raukadah
Copy link
Contributor

raukadah commented Jul 9, 2025

/ok-to-test

@morenod morenod force-pushed the enable_prometheus_admin_api branch from a18a38c to 246124e Compare July 9, 2025 10:55
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8bb352e6450940e493ffe89d7380692f

✔️ openstack-meta-content-provider-master SUCCESS in 2h 57m 02s
✔️ watcher-operator-validation-master SUCCESS in 2h 07m 21s (non-voting)
✔️ openstack-meta-content-provider-epoxy SUCCESS in 2h 08m 39s
✔️ watcher-operator-validation-epoxy SUCCESS in 1h 44m 17s
✔️ watcher-operator-validation-epoxy-ocp4-16 SUCCESS in 1h 45m 19s
✔️ noop SUCCESS in 0s
watcher-operator-kuttl RETRY_LIMIT in 16m 21s

@morenod
Copy link
Author

morenod commented Jul 9, 2025

recheck

@raukadah
Copy link
Contributor

raukadah commented Jul 9, 2025

@raukadah
Copy link
Contributor

raukadah commented Jul 9, 2025

/approve

Copy link

openshift-ci bot commented Jul 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raukadah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants