-
Notifications
You must be signed in to change notification settings - Fork 21
Enable prometheus admin API to allow us to delete old injected metrics #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Enable prometheus admin API to allow us to delete old injected metrics #214
Conversation
Hi @morenod. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9030c4b7e3e84b1d8e2014cb8e27bcac ✔️ openstack-meta-content-provider-master SUCCESS in 1h 44m 59s |
dee82ef
to
4a85dc1
Compare
recheck |
dd46803
to
a18a38c
Compare
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d4426cb48d8546afadb77dbc9fc7f913 Warning: |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d20fd5d008684530bfbfc572a19caf65 Warning: |
recheck |
/ok-to-test |
a18a38c
to
246124e
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8bb352e6450940e493ffe89d7380692f ✔️ openstack-meta-content-provider-master SUCCESS in 2h 57m 02s |
recheck |
Based on this https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954433/2#message-17270e3781a8f61f3843232a570d2cb2eca4073c, it is working now! |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We need to delete injected metrics between tests to avoid overlapping between tests
This can be done by enabling this API and executing requests like [1]
There is no option (by now) to do it on the openstackcontrolplane object, so now we have to patch prometheus after it is created, we will manage to add an option to include this API on the controlplane object [2]
[1] https://metric-storage-prometheus.openstack.svc:9090/api/v1/admin/tsdb/delete_series?match[]={job="promtool"}
[2] https://github.com/rhobs/observability-operator/blob/d0e25a27bde3ba2ca6c39a6fb259e93c8ae8cc99/pkg/apis/monitoring/v1alpha1/types.go#L177