UI updates: icons, validation colors, clear validation on input#7
Open
jivey wants to merge 14 commits into
Open
UI updates: icons, validation colors, clear validation on input#7jivey wants to merge 14 commits into
jivey wants to merge 14 commits into
Conversation
jivey
commented
Jul 15, 2026
| run: pip install cfn-lint | ||
|
|
||
| - name: Run cfn-lint | ||
| run: cfn-lint |
Member
Author
There was a problem hiding this comment.
I think this is failing because we don't have cfn files in the repo yet - maybe we remove this or add an if: false to skip until we need it
There was a problem hiding this comment.
Pull request overview
This PR updates CUTIE client UI/UX around validation and feedback presentation (CORE-2453), focusing on clearer invalid-state styling, improved icon alignment, and real-time clearing of certain validation errors after user edits.
Changes:
- Adds/standardizes
aria-invalid="true"visual styling across multiple interactions and feedback components. - Refactors validation handling for text-entry and formula interactions to clear error state on input once values become valid (with new/updated tests).
- Updates feedback/validation icon SVG configuration and adjusts CI to run checks across more workspace packages.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/cutie-example/src/utils/ai.ts | Fixes a spelling error in a Zod schema description string. |
| packages/cutie-client/src/transformer/handlers/textEntryInteraction.ts | Refactors pattern-mask validation and adds invalid-state styling + real-time error clearing. |
| packages/cutie-client/src/transformer/handlers/textEntryInteraction.spec.ts | Adds tests for clearing/not surfacing errors during input. |
| packages/cutie-client/src/transformer/handlers/inlineChoiceInteraction.ts | Adds invalid-state styling for inline choice interaction. |
| packages/cutie-client/src/transformer/handlers/gapMatchInteraction/styles.ts | Adjusts disabled border color styling for gap-match inputs. |
| packages/cutie-client/src/transformer/handlers/feedback/feedbackInline.ts | Tweaks inline feedback icon vertical alignment. |
| packages/cutie-client/src/transformer/handlers/feedback/feedbackIcons.ts | Updates icon path/viewBox handling and icon baseline alignment. |
| packages/cutie-client/src/transformer/handlers/feedback/feedbackIcons.spec.ts | Updates tests to assert per-icon viewBox values. |
| packages/cutie-client/src/transformer/handlers/feedback/feedbackBlock.ts | Improves feedback-block layout and icon alignment using CSS variables. |
| packages/cutie-client/src/transformer/handlers/extendedText/richText.ts | Adds invalid-state styling for rich text wrapper when inner editor is invalid. |
| packages/cutie-client/src/transformer/handlers/extendedText/plainText.ts | Adds invalid-state styling for textarea extended text. |
| packages/cutie-client/src/transformer/handlers/extendedText/formula.ts | Refactors required validation and clears error state on input; adds invalid styling. |
| packages/cutie-client/src/transformer/handlers/extendedText/formula.spec.ts | Adds a test ensuring formula error clears on input when valid. |
| packages/cutie-client/src/styles/baseStyles.ts | Introduces a --cutie-line-height CSS variable and uses it for base line-height. |
| packages/cutie-client/src/errors/validationDisplay.ts | Updates constraint icon/typography styling and switches constraint icon viewBox. |
| .github/workflows/lint.yml | Updates lint workflow runner image to ubuntu-latest. |
| .github/workflows/ci.yml | Updates Jira-linked action version and expands the module matrix to multiple packages. |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:36
- With the new 4-entry module matrix, each matrix job still runs
yarn buildat the repo root, which builds all workspaces every time (seescripts/build.bash). This multiplies build time by the matrix size. Consider either building only what the current module needs, or restructuring CI to build once and reuse artifacts/caches across matrix jobs.
strategy:
fail-fast: false
matrix:
module: [cutie-core, cutie-client, cutie-editor, cutie-example]
env:
CI: true
steps:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: actions/setup-node@v3
with:
node-version-file: .nvmrc
cache: yarn
- run: yarn install --immutable
- run: yarn build
- run: yarn ci
working-directory: packages/${{ matrix.module }}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-2453