Fix swapped verbose_name/help_text on Book salesforce fields#1743
Merged
Conversation
salesforce_abbreviation is the field os-webview actually uses for form display/dedup and Partner filtering; salesforce_name is the one synced against the Salesforce Book__c list. Their admin labels/help text were swapped, telling editors the opposite of what each field does.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request corrects Wagtail admin editor guidance for two Book Salesforce-related fields by swapping their verbose_name and help_text to match each field’s actual purpose, and includes the corresponding Django migration to apply that metadata change.
Changes:
- Swap
verbose_name/help_textbetweenBook.salesforce_abbreviationandBook.salesforce_nameinbooks/models.py. - Add a Django migration altering both fields to persist the admin label/help-text fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| books/models.py | Fixes the admin-facing labels/help text for the two Salesforce fields so editors get correct guidance. |
| books/migrations/0173_alter_book_salesforce_abbreviation_and_more.py | Applies the field metadata changes via AlterField operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Book.salesforce_abbreviationandBook.salesforce_namewere swapped, telling editors the opposite of what each field actually does.salesforce_abbreviationis the field os-webview uses for form display/dedup and Partner filtering (seeos-webviewhelpers/books.ts,after-form-submit.ts,partner-details.tsx).salesforce_nameis the field validated against the synced SalesforceBook__clist (BookAdminFormdropdown inbooks/models.py).verbose_name/help_textswapped, with the corresponding Django migration for that state change.Test plan
python manage.py test books --settings=openstax.settings.test— 33/33 passing