-
Notifications
You must be signed in to change notification settings - Fork 296
Update +ify orthography rule #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not sure which category of news fragment this should have - dict feels the closest. |
|
Hey @Shrimpy48 — thanks a ton for opening this! I'm afraid the PR needs to be updated to resolve the conflicts. We very recently added code formatting with Ruff. While we're touching the rule, might make sense to further extend the regex so it only fires when the final i/y is preceded by a consonant? Something like:
If you’re busy or no longer working on this, just let me know — I’m happy to pick it up and push it over the line. Either way, really appreciate the contribution! |
8882da8 to
bb65891
Compare
|
Hey there, thanks for getting back to me on this! No worries about the delay. The preceding vowel case is tricky. Maybe the rule should fire for vowel+"i" (Hawaiification, ASCIIfication, Dubaification) but not for vowel+"y" (playification, joyification)? |
|
Yes, that sounds good. There'll always be exceptions to this (and many other) rule but it will cover the majority of cases. |
|
The changes look very good, thanks for that! Regarding the news file, I'd vote for "core" to make it more clear that it's changing the system rules and not adding some entries to the dictionary. |
|
OK, I've added a news fragment now, thank you! |
mkrnr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the improvement!
Summary of changes
Orthography rule for words ending in i + ify suffix updated to also cover words ending in y.
Closes #1678
Pull Request Checklist