Skip to content

Conversation

@Shrimpy48
Copy link
Contributor

@Shrimpy48 Shrimpy48 commented Jul 19, 2024

Summary of changes

Orthography rule for words ending in i + ify suffix updated to also cover words ending in y.

Closes #1678

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

@Shrimpy48
Copy link
Contributor Author

I'm not sure which category of news fragment this should have - dict feels the closest.

@mkrnr
Copy link
Contributor

mkrnr commented Jun 28, 2025

Hey @Shrimpy48 — thanks a ton for opening this!
(And sorry it’s taken me a while to get to it.)

I'm afraid the PR needs to be updated to resolve the conflicts. We very recently added code formatting with Ruff.

While we're touching the rule, might make sense to further extend the regex so it only fires when the final i/y is preceded by a consonant? Something like:
(r"^(.+[^aeiou])[iy] \^ if(y|ying|ied|ies|ication|ications)$", r"\1if\2")
Examples that we can add to the tests would be:

  • Hawaii + -ification should be Hawaiification
  • play + -ification should be playification

If you’re busy or no longer working on this, just let me know — I’m happy to pick it up and push it over the line. Either way, really appreciate the contribution!

@Shrimpy48 Shrimpy48 force-pushed the prettify-orthography branch from 8882da8 to bb65891 Compare June 29, 2025 22:01
@Shrimpy48
Copy link
Contributor Author

Hey there, thanks for getting back to me on this! No worries about the delay.
I'm happy to carry on with it.

The preceding vowel case is tricky. Maybe the rule should fire for vowel+"i" (Hawaiification, ASCIIfication, Dubaification) but not for vowel+"y" (playification, joyification)?

@mkrnr
Copy link
Contributor

mkrnr commented Jun 30, 2025

Yes, that sounds good. There'll always be exceptions to this (and many other) rule but it will cover the majority of cases.

@mkrnr
Copy link
Contributor

mkrnr commented Jun 30, 2025

The changes look very good, thanks for that! Regarding the news file, I'd vote for "core" to make it more clear that it's changing the system rules and not adding some entries to the dictionary.

@Shrimpy48
Copy link
Contributor Author

OK, I've added a news fragment now, thank you!

Copy link
Contributor

@mkrnr mkrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the improvement!

@mkrnr mkrnr merged commit 65fc2b4 into opensteno:main Jul 1, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grammar] Stroking PREUT/TPAOEU outputs 'prettyify' even though the correct form is "prettify"

2 participants