Skip to content

Conversation

@user202729
Copy link
Member

@user202729 user202729 commented Mar 4, 2025

According to pypa/setuptools#4862 , specifying extra for entrypoint is deprecated. And as I explained there, it breaks some features (in particular if that is used then gui_qt no longer work on my machine).

The simplest way seems to be just remove the extra specification.

Pull Request Checklist

  • Changes have tests
  • News fragment added in news.d. See documentation for details

@user202729 user202729 force-pushed the fix-hyphen-extra-requirement branch from dcda3f0 to 6f1b715 Compare March 5, 2025 09:47
@user202729 user202729 marked this pull request as ready for review March 5, 2025 09:48
@mkrnr mkrnr changed the title Change underscore to hyphen in extra requirement Remove deprecated extra gui_qt from setup.cfg Mar 6, 2025
@mkrnr mkrnr self-requested a review March 6, 2025 05:46
Copy link
Contributor

@mkrnr mkrnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Also did a quick test on the PySide6 branch and removing this didn't seem to have any impact.

Feel free to merge the PR.

@user202729 user202729 merged commit 1234ae6 into opensteno:main Mar 6, 2025
12 checks passed
@tsprlng
Copy link

tsprlng commented Apr 4, 2025

This change seems to break the build on MacOS (at least locally for me), causing the check_requirements step at the end of osx/make_app.sh to fail with pkg_resources.UnknownExtra: plover 4.0.0 has no such extra feature 'gui_qt' -- not sure why though. Probably it's related to the MacOS builds pinning a 3.9 version of Python when assembling the app?

@tsprlng tsprlng mentioned this pull request Apr 4, 2025
@tsprlng
Copy link

tsprlng commented Apr 4, 2025

(Is this PySide6 branch up anywhere, out of interest?)

@user202729
Copy link
Member Author

user202729 commented Apr 4, 2025

Understandable, given Plover uses quite a lot of pkg_resources sanity check internally. (Sometimes the sanity check is a bit too strict though. This one probably qualifies.)

See also #1703

Given the above, and the fact that dependency on entry point itself is going to be deprecated, it's probably sufficient if we just remove the relevant check.

(The PySide6 branch is at #1601 . )

zedseven added a commit to zedseven/nixos-configuration that referenced this pull request Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants