Wait for all keys to be released before grabbing #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilleAila
approved these changes
May 20, 2025
Contributor
LilleAila
left a comment
LilleAila
left a comment
There was a problem hiding this comment.
LGTM. haven't tried running the code locally, but it looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Makes uinput module wait for all keys on each input device to be released before grabbing the device. This prevents keys from being stuck when keys are held while Plover is starting.
Device grabbing was moved from
_runtostartto show that the keyboard is still connecting in the UI while waiting for keys to be released (self._runningis only set when keys are grabbed)Pull Request Checklist