feat: implement SSRF guard to block private/internal IP fetches and a…#51
Open
anushkrishnav wants to merge 1 commit into
Open
feat: implement SSRF guard to block private/internal IP fetches and a…#51anushkrishnav wants to merge 1 commit into
anushkrishnav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47
Fixes CWE-918 (Server-Side Request Forgery) in the WebFetch tool.
Problem
WebFetch performed zero host/IP validation before fetching URLs. Any
http:// URL — including http://169.254.169.254/ (cloud metadata) and
RFC-1918 LAN addresses — passed through.
follow_redirects=Truemadeit worse: a public URL redirecting to an internal address bypassed any
hypothetical scheme-only check entirely.
Changes
tools/ssrf_guard.py(new): single source of truth for theblocked-network list (loopback, link-local/cloud-metadata, RFC-1918,
CGN, IPv6 ULA). Exposes
is_safe_url()andassert_safe_url()/SSRFBlockedError.tools/web.py: replacedfollow_redirects=Truewith a manual_safe_fetch()that callsassert_safe_url()on the initial URLand every
Locationheader before following it.apps/web/web.py:/api/web/fetchcallsassert_safe_url()before any cascade — returns HTTP 422 if blocked.
web_mcp_server.py: importsis_safe_urlfromssrf_guard(fail-closed fallback if package unavailable); checks URL after the
scheme guard.
Tests
42 new tests in
tests/test_ssrf_guard.pycovering: