-
Notifications
You must be signed in to change notification settings - Fork 6
NanoTDF Resource Locator KID #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2024
Co-authored-by: Dave Mihalcik <[email protected]>
strantalis
previously approved these changes
Jul 30, 2024
This was referenced Aug 2, 2024
Closed
pflynn-virtru
added a commit
to opentdf/java-sdk
that referenced
this pull request
Aug 7, 2024
This is prep for the incoming changes related to ADR below. Updated the constructor to mask the first byte with 0xF, ensuring only the first four bits are used for indexing the protocol. This prevents potential out-of-bounds errors when retrieving values from the NanoTDFType.Protocol enum. Issue: opentdf/platform#1203 Specification: opentdf/spec#40 ADR: opentdf/platform#900
Consolidated protocol and identifier values into a cleaner format by merging redundant rows and aligning columns. Also fixed a typo in the note about unreserved values and clarified version-specific information regarding the "Shared Resource Directory" flag.
pflynn-virtru
commented
Aug 12, 2024
Clarified the length constraints for the Ephemeral Public Key in the nanotdf schema documentation. This ensures better understanding and consistency regarding the expected byte sizes.
strantalis
approved these changes
Aug 12, 2024
This was referenced Aug 14, 2024
pflynn-virtru
added a commit
to opentdf/java-sdk
that referenced
this pull request
Aug 15, 2024
NanoTDF will now have the KAS KID set in the KAS ResourceLocator Resolves #100 Specification: opentdf/spec#40 ADR: opentdf/platform#900
github-merge-queue bot
pushed a commit
to opentdf/platform
that referenced
this pull request
Aug 23, 2024
…#1222) - Adds `identifier` field to Resource Locator - Updates Protocol Enum with `identifier ` size Closes #1203 Issue: #1203 Specification: opentdf/spec#40 ADR: #900 --------- Co-authored-by: sujankota <[email protected]> Co-authored-by: David Mihalcik <[email protected]> Co-authored-by: Tyler Biscoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Checklist
draft-<change>
git tag -s 4.1.0 -m "Spec version 4.1.0 - did a thing"
)