Skip to content

NanoTDF Resource Locator KID #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2024
Merged

Conversation

pflynn-virtru
Copy link
Member

Proposed Changes

  • Adds Identifier to Protocol Enum
  • Require Identifier in KAS Resource Locator

Checklist

  • A clear description of the change has been included in this PR.
  • A clear description of whether this change is a Major, Minor, Patch or cosmetic change as per the Versioning Guidelines has been included in this PR.
  • All schema validation tests have been updated appropriately and are passing.
  • MAJOR/MINOR VERSION CHANGES ONLY: This PR should be made in branches prefixed with draft-<change>
  • MAJOR/MINOR VERSION CHANGES ONLY: A link to a reference implementation (PR or set of PRs) of the change has been included in this PR.
  • MAJOR/MINOR VERSION CHANGES ONLY: A writeup has been included discussing the motivation and impact of this change.
  • MAJOR/MINOR VERSION CHANGES ONLY: The minimum wait time has elapsed.
  • DRAFT MERGE ONLY: Draft Semver has been updated in the VERSION file (optional)
  • DRAFT MERGE ONLY: Tagged this branch with new semver version and an annotation describing the change (ex: git tag -s 4.1.0 -m "Spec version 4.1.0 - did a thing")
  • DRAFT MERGE ONLY: Version numbers have been updated as per the Versioning Guidelines.
  • This change otherwise adheres to the project Contribution Guidelines.

strantalis
strantalis previously approved these changes Jul 30, 2024
pflynn-virtru added a commit to opentdf/java-sdk that referenced this pull request Aug 7, 2024
This is prep for the incoming changes related to ADR below.

Updated the constructor to mask the first byte with 0xF, ensuring only
the first four bits are used for indexing the protocol. This prevents
potential out-of-bounds errors when retrieving values from the
NanoTDFType.Protocol enum.

Issue: opentdf/platform#1203
Specification: opentdf/spec#40
ADR: opentdf/platform#900
Consolidated protocol and identifier values into a cleaner format by merging redundant rows and aligning columns. Also fixed a typo in the note about unreserved values and clarified version-specific information regarding the "Shared Resource Directory" flag.
@pflynn-virtru pflynn-virtru marked this pull request as ready for review August 12, 2024 15:19
@pflynn-virtru pflynn-virtru requested a review from a team as a code owner August 12, 2024 15:19
Clarified the length constraints for the Ephemeral Public Key in the nanotdf schema documentation. This ensures better understanding and consistency regarding the expected byte sizes.
pflynn-virtru added a commit to opentdf/java-sdk that referenced this pull request Aug 15, 2024
NanoTDF will now have the KAS KID set in the KAS ResourceLocator

Resolves #100
Specification: opentdf/spec#40
ADR: opentdf/platform#900
github-merge-queue bot pushed a commit to opentdf/platform that referenced this pull request Aug 23, 2024
…#1222)

- Adds `identifier` field to Resource Locator
- Updates Protocol Enum with `identifier `  size

Closes #1203 
Issue: #1203 
Specification: opentdf/spec#40
ADR: #900

---------

Co-authored-by: sujankota <[email protected]>
Co-authored-by: David Mihalcik <[email protected]>
Co-authored-by: Tyler Biscoe <[email protected]>
@pflynn-virtru pflynn-virtru merged commit f7b8dd0 into main Sep 26, 2024
@pflynn-virtru pflynn-virtru deleted the feature/nano-kid-resource-locator branch September 26, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants