-
Notifications
You must be signed in to change notification settings - Fork 4
feat: add overflow mode and auto-scroll options to SuggestionPills co… #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…mponent - Introduced `overflowMode` prop to control how excess items are displayed: either by expanding or scrolling. - Added `autoScrollOnHover` prop to enable automatic scrolling to visible items when hovered. - Updated documentation to reflect new properties and their functionalities. - Enhanced event handling in the SuggestionPills component for improved user experience.
Caution Review failedThe pull request is closed. WalkthroughThe SuggestionPills component and its documentation were updated to support two new props: Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant SuggestionPills
participant PillButtonWrapper
User->>SuggestionPills: Hover or click pill
alt overflowMode = 'scroll' and autoScrollOnHover = true
PillButtonWrapper->>SuggestionPills: mouseenter event
SuggestionPills->>SuggestionPills: scrollIntoViewIfPartiallyHidden()
end
User->>SuggestionPills: Click "show more" (if overflowMode = 'expand')
SuggestionPills->>SuggestionPills: Expand and show all pills
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/components/src/suggestion-pills/components/PillButtonWrapper.vueOops! Something went wrong! :( ESLint: 9.30.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. docs/demos/suggestion/pills-popper-config.vueOops! Something went wrong! :( ESLint: 9.30.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it. packages/components/src/suggestion-pills/index.type.tsOops! Something went wrong! :( ESLint: 9.30.0 Error: The 'jiti' library is required for loading TypeScript configuration files. Make sure to install it.
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
…mponent
overflowMode
prop to control how excess items are displayed: either by expanding or scrolling.autoScrollOnHover
prop to enable automatic scrolling to visible items when hovered.Summary by CodeRabbit
New Features
Bug Fixes
Documentation