chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" #1742

kagol · 2024-07-11T08:03:29Z

PR

解决 GitHub Actions 跑 E2E 测试时执行 pnpm i 报以下问题：

.../node_modules/@parcel/watcher install$ node-gyp-build
.../node_modules/vue-demi postinstall$ node -e "try{require('./scripts/postinstall.js')}catch(e){}"
.../node_modules/@parcel/watcher install: Done
.../node_modules/vue-demi postinstall: Done
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall$ node install.js
.../[email protected]/node_modules/esbuild postinstall: Done
.../[email protected]/node_modules/esbuild postinstall: Done
.../.pnpm/[email protected]/node_modules/nx postinstall$ node ./bin/compute-project-graph
.../[email protected]/node_modules/esbuild postinstall: /home/runner/work/tiny-vue/tiny-vue/node_modules/.pnpm/[email protected]/node_modules/esbuild/install.js:134
.../[email protected]/node_modules/esbuild postinstall:     throw new Error(`Expected ${JSON.stringify(versionFromPackageJSON)} but got ${JSON.stringify(stdout)}`);
.../[email protected]/node_modules/esbuild postinstall:           ^
.../[email protected]/node_modules/esbuild postinstall: Error: Expected "0.23.1" but got "0.17.19"
.../[email protected]/node_modules/esbuild postinstall:     at validateBinaryVersion (/home/runner/work/tiny-vue/tiny-vue/node_modules/.pnpm/[email protected]/node_modules/esbuild/install.js:134:11)
.../[email protected]/node_modules/esbuild postinstall:     at /home/runner/work/tiny-vue/tiny-vue/node_modules/.pnpm/[email protected]/node_modules/esbuild/install.js:284:5
.../[email protected]/node_modules/esbuild postinstall: Failed
 ELIFECYCLE  Command failed with exit code 1.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Chores
- Updated Node.js version from 16 to 20 in various GitHub Actions workflows for improved compatibility and performance.

coderabbitai · 2024-07-11T08:03:39Z

Walkthrough

The updates across the GitHub workflow files involve changing the Node.js version from 16 to 20. This upgrade affects the test-e2e-all, test-e2e-dispatch, and test-e2e-pr workflows, aiming to leverage improvements and new features available in Node.js 20.

Changes

Files	Change Summary
`.github/workflows/test-e2e-all.yml`	Updated the Node.js version from 16 to 20 for setting up the node environment.
`.github/workflows/test-e2e-dispatch.yml`	Updated the Node.js version from 16 to 20 in the setup step.
`.github/workflows/test-e2e-pr.yml`	Updated the Node.js version from 16 to 20 in the setup configuration for Playwright testing.

Poem

Node version twenty, now in play,
For all our tests, it leads the way.
E2E checks run smooth and bright,
A future built on code so tight.
With each commit, in workflows clear,
Our project's progress, drawing near. ✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2024-07-11T08:04:08Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

coderabbitai

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ff0ec5b and efafce9.

Files selected for processing (3)

.github/workflows/test-e2e-all.yml (2 hunks)
.github/workflows/test-e2e-dispatch.yml (1 hunks)
.github/workflows/test-e2e-pr.yml (1 hunks)

Files skipped from review due to trivial changes (3)

.github/workflows/test-e2e-all.yml
.github/workflows/test-e2e-dispatch.yml
.github/workflows/test-e2e-pr.yml

chore: update workflow node-version to 20

efafce9

kagol added the ci CI/CD （流水线持续集成） label Jul 11, 2024

zzcr approved these changes Jul 11, 2024

View reviewed changes

zzcr merged commit f19e3f1 into dev Jul 11, 2024
3 of 7 checks passed

coderabbitai bot reviewed Jul 11, 2024

View reviewed changes

kagol changed the title ~~chore: update workflow node-version to 20~~ chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" Aug 19, 2024

kagol deleted the kagol/update-node-version branch November 4, 2024 03:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" #1742

chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" #1742

Uh oh!

kagol commented Jul 11, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" #1742

chore: update workflow node-version to 20 to fix Error: Expected "0.23.1" but got "0.17.19" #1742

Uh oh!

Conversation

kagol commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Jul 11, 2024

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kagol commented Jul 11, 2024 •

edited

Loading

coderabbitai bot commented Jul 11, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)