fix(load-list): avoid tinyList and tinyTimeLine regisiter twice #2854
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
You can disable this status message by setting the WalkthroughThis PR updates component exclusion logic and refines component validation. It adds the new component Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough此PR修复了loadList组件的注册问题，将其注册名称修改为tinyLoadList，并在总入口处屏蔽了time-line-new包的注册。此更改旨在避免tinyList和tinyTimeLine组件的重复注册问题。 Changes
🪧 TipsFor further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
internals/cli/src/commands/build/build-entry-app.ts(1 hunks)internals/cli/src/shared/module-utils.ts(1 hunks)packages/vue/src/load-list/src/index.ts(2 hunks)
🔇 Additional comments (3)
packages/vue/src/load-list/src/index.ts (1)
7-7: LGTM! Modern array method usage.The change from
indexOf > -1toincludesimproves code readability while maintaining the same functionality.internals/cli/src/commands/build/build-entry-app.ts (1)
115-115: LGTM! Consistent with PR objectives.Adding 'TimeLineNew' to
notSimpleComponentscorrectly implements the PR objective to disable the time-line-new package from the main entry point.internals/cli/src/shared/module-utils.ts (1)
17-17: LGTM! Consistent component exclusion.Adding 'TimeLineNew' to
excludeComponentsmaintains consistency with its exclusion innotSimpleComponents, ensuring the component is properly excluded from processing.
| @@ -19,7 +19,7 @@ export const loadListProps = { | |||
| } | |||
|
|
|||
| export default defineComponent({ | |||
| name: $prefix + 'List', | |||
| name: $prefix + 'LoadList', | |||
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Verify component name change impact.
The component has been renamed from List to LoadList. While this name is more descriptive, it's a breaking change that could affect existing usage.
Run this script to find potential usages that need updating:
🏁 Script executed:
#!/bin/bash
# Search for any imports or usage of the old component name
rg -l "(?:import|from).*List['\"]|(?:<|@)tiny-list" Length of output: 319
Breaking change detected due to component rename
- The component was renamed from
ListtoLoadListinpackages/vue/src/load-list/src/index.ts. - The grep output indicates that the following demo files still reference the old component (likely via tags like
<tiny-list>or similar):examples/sites/demos/mobile/app/list/slots.vueexamples/sites/demos/mobile/app/list/single-line.vueexamples/sites/demos/mobile/app/list/double-line.vueexamples/sites/demos/mobile/app/list/double-list.vueexamples/sites/demos/mobile/app/list/imformation-list.vue
These usages need to be updated to reflect the new LoadList name to prevent breakage.
shenjunjian
changed the title
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2832
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Chores