Skip to content

fix(input): [input] fix textarea word wrap style #2899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Conversation

gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Feb 13, 2025

PR

多端模板,textarea只读态设置文本换行

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Introduced a new, read-only text area that includes a "show more" popup to reveal lengthy content.
    • Added a demo featuring multilingual support to showcase the new text field functionality.
  • Refactor

    • Enhanced mobile text readability by updating the display method to preserve whitespace and line breaks through preformatted styling.

@github-actions github-actions bot added the bug Something isn't working label Feb 13, 2025
Copy link

coderabbitai bot commented Feb 13, 2025

Walkthrough

This pull request introduces a new Vue component (display-only-popup-more.vue) that renders a read-only textarea with a popup option to view overflow text. A corresponding demo entry is added in input.js to document the feature. Additionally, the rendering of text within the tiny-dialog-box component in mobile-first.vue is updated to use a <pre> element, ensuring that whitespace and line breaks are preserved.

Changes

File(s) Changes
examples/sites/demos/mobile-first/app/input/display-only-popup-more.vue Added a new Vue component that uses a tiny-input (configured as a textarea) with a popup feature for displaying long, read-only text.
examples/sites/demos/mobile-first/app/input/webdoc/input.js Added a new demo entry with id display-only-popup-more, including translations and a description of the read-only popup feature.
packages/vue/src/input/src/mobile-first.vue Modified the rendering within the tiny-dialog-box component by replacing a <div> with a <pre> element to preserve text formatting.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant C as display-only-popup-more Component
  participant T as TinyInput
  
  U->>C: Views read-only text
  alt Text exceeds visible area
      U->>C: Clicks "Show More" button
      C->>T: Triggers popup display
      T-->>U: Shows full, preformatted text in popup
  else Text within limits
      U-->>C: Reads text normally
  end
Loading

Possibly related PRs

Suggested reviewers

  • zzcr

Poem

I'm a rabbit hopping through lines of code,
With a shiny new component in my humble abode.
Popups and preformatted text dance in the light,
Making all my coding days ever so bright.
Hop along, dear devs, let the updates ignite!
🐰✨

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Walkthrough

此PR修复了textarea在只读模式下的文本换行问题,确保文本内容在超过一定行数时自动隐藏,并提供“显示更多”按钮以查看完整内容。

Changes

文件路径 概要
examples/sites/demos/mobile-first/app/input/display-only-popup-more.vue 添加了一个新的示例组件,展示了textarea在只读模式下的文本换行和“显示更多”功能。
examples/sites/demos/mobile-first/app/input/webdoc/input.js 更新了文档,增加了关于textarea只读模式下“显示更多”功能的描述。
packages/vue/src/input/src/mobile-first.vue 修改了textarea的展示方式,使用<pre>标签替代<div>以支持文本换行。

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Walkthrough

This PR fixes text line breaking issues in read-only mode, ensuring that text content is automatically hidden when more than a certain number of lines is available, and provides a "Show More" button to view the full content.

Changes

File path Summary
examples/sites/demos/mobile-first/app/input/display-only-popup-more.vue Added a new sample component that shows text wrapping and "Show more" in read-only mode for textarea Function.
examples/sites/demos/mobile-first/app/input/webdoc/input.js Updated documentation and added a description of the "Show More" feature in textarea read-only mode.
packages/vue/src/input/src/mobile-first.vue Modify the display method of textarea, using the <pre> tag instead of <div> to support text wrapping.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
examples/sites/demos/mobile-first/app/input/display-only-popup-more.vue (2)

16-17: Consider internationalizing the demo text.

The hardcoded Chinese text in the demo should be internationalized to support multiple languages.

-      input:
-        '表单文本域开启只读模式,\n文本内容超过 5 行自动隐藏。\n表单文本域开启只读模式,\n文本内容超过 5 行自动隐藏。\n表单文本域开启只读模式,\n文本内容超过 5 行自动隐藏。\n表单文本域开启只读模式,\n文本内容超过 5 行自动隐藏。\n表单文本域开启只读模式,\n文本内容超过 5 行自动隐藏'
+      input: this.$t('demo.input.displayOnlyPopupMore.text')

24-26: Consider using responsive width.

The fixed width of 260px might not be optimal for all screen sizes. Consider using relative units or media queries for better responsiveness.

-.demo-input .tiny-textarea {
-  width: 260px;
-}
+.demo-input .tiny-textarea {
+  width: 100%;
+  max-width: 260px;
+}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 13b5a25 and 2df0c8b.

📒 Files selected for processing (3)
  • examples/sites/demos/mobile-first/app/input/display-only-popup-more.vue (1 hunks)
  • examples/sites/demos/mobile-first/app/input/webdoc/input.js (1 hunks)
  • packages/vue/src/input/src/mobile-first.vue (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/vue/src/input/src/mobile-first.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
examples/sites/demos/mobile-first/app/input/webdoc/input.js (1)

512-525: LGTM! Well-documented demo entry.

The new demo entry is well-structured with clear descriptions in both Chinese and English, following the established pattern of other demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants