Skip to content

feat(input): [input] input component adapts to dark theme #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Feb 22, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Style
    • Enhanced the visual appearance of read-only input fields by applying a refined text color scheme, ensuring that content is easily legible and consistent with the overall design.
    • Simplified the textarea presentation by eliminating unnecessary decorative elements, resulting in a cleaner interface that emphasizes clear, readable display-only content and contributes to a modern user experience.

@github-actions github-actions bot added the enhancement New feature or request (功能增强) label Feb 22, 2025
Copy link

Walkthrough

This PR updates the input and textarea components to adapt to a dark theme by modifying their styles. It introduces new CSS variables for text color and removes unnecessary pseudo-elements to streamline the styling for dark mode compatibility.

Changes

Files Changed Summary
packages/theme/src/input/index.less Added a new CSS variable for text color to support dark theme.
packages/theme/src/textarea/index.less Removed unnecessary pseudo-elements and added a new CSS variable for text color to support dark theme.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@zzcr zzcr changed the title feat(input): input component adapts to dark theme feat(input): [input] input component adapts to dark theme Feb 22, 2025
Copy link

coderabbitai bot commented Feb 22, 2025

Walkthrough

This pull request adjusts the styling for input and textarea components. In the input component, a new text color rule is added to the .is-display-only state for the content. In the textarea component, several pseudo-elements and related styles (including those for disabled and display-only states) are removed, streamlining its appearance. Additionally, a new text color rule is introduced for the display-only content in the textarea. No changes affect exported or public entities.

Changes

File Change Summary
packages/theme/src/input/index.less Added a new line in the .is-display-only block to set the text color for &__content using var(--tv-Input-text-color), with no changes to existing properties.
packages/theme/src/textarea/index.less Removed the :before and :after pseudo-elements along with associated styling in the textarea; modified styles in .is-disabled and .is-display-only classes; added a text color for display-only content using var(--tv-Textarea-text-color).

Possibly Related PRs

Poem

I'm a little rabbit, hopping through the code,
Adding colors where design once flowed.
Input and textarea now wear brighter hues,
Removing old shells to bring fresh views.
In the world of style, we hop and play—
A tiny tweak makes a big display! 🐇🎨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 37f3f45 and 371d61a.

📒 Files selected for processing (2)
  • packages/theme/src/input/index.less (1 hunks)
  • packages/theme/src/textarea/index.less (1 hunks)
🔇 Additional comments (3)
packages/theme/src/textarea/index.less (2)

19-20: Validate Variable Declaration with String Interpolation

The updated declarations for @textarea-prefix-cls and @input-prefix-cls that use the tilde for string interpolation appear to be correctly defined. Please ensure the referenced variable @{css-prefix} is properly set in your theme configuration or imported files.


164-164: New Display-Only Text Color Rule Added

A new color: var(--tv-Textarea-text-color); rule has been introduced within the .@{textarea-prefix-cls}-display-only__content block to adapt the textarea component for dark theme. This aligns with our dark theme strategy.
Please double-check that the CSS variable --tv-Textarea-text-color is defined in the theme configuration to avoid styling issues.

packages/theme/src/input/index.less (1)

288-288: Introduce Text Color for Display-Only Input Content

The addition of the color: var(--tv-Input-text-color); rule in the display-only content area ensures consistency with dark theme requirements by explicitly setting the text color.
Please verify that the CSS variable --tv-Input-text-color is defined in the theme configuration.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zzcr zzcr merged commit d35c051 into dev Feb 24, 2025
15 of 16 checks passed
@kagol kagol deleted the fix-input-dark-style branch April 14, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request (功能增强)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants