fix(crop): [crop] change theme

[James-9696]

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Style
  • Enhanced the crop selection interface with dynamic theming options that adjust background colors, shadows, and icon hover effects.
  • Introduced new CSS custom properties for improved customization, including background and icon colors, hover effects, and shadow settings for a more adaptable and visually consistent appearance.

[coderabbitai]

Walkthrough

The changes update the crop component's CSS styling. Fixed color values in index.less have been replaced with CSS variables, allowing for more dynamic theming. Additionally, vars.less now defines several new CSS custom properties for background, font, hover, box shadow, and split colors. No public API declarations were modified.

Changes

File(s)	Summary
packages/.../crop/index.less	Replaced fixed colors and shadow values with CSS variables in classes for dialog handle, icon button set, hover states, and split styling.
packages/.../crop/vars.less	Introduced new CSS custom properties (--tv-Crop-select-bg-color, --tv-Crop-select-icon-color, --tv-Crop-select-icon-color-hover, --tv-Crop-select-box-shadow-color, --tv-Crop-select-box-split-bg-color) for theming the crop component.

Possibly related PRs

• feat(theme): modify variable names and add reset styles #2185: The changes in the main PR are related to the new CSS custom properties introduced in the retrieved PR, as they both involve modifications to CSS variables used for styling components.
• fix(color-select-panel): [color-select-panel] change theme #3043: The changes in the main PR are related to the introduction of new CSS variables that are used for styling, which aligns with the modifications in the retrieved PR that also involves the addition of a new CSS variable for styling purposes.
• feat(theme): [button] add dark themes, modify other theme variables and component level variables #2898: The changes in the main PR are related to the introduction of new CSS variables for theming, which aligns with the modifications in the retrieved PR that also focuses on updating styles to utilize CSS variables, indicating a shared goal of enhancing theming flexibility.

Suggested labels

enhancement

Suggested reviewers

• zzcr

Poem

I'm a hopping rabbit, leaping with delight,
CSS colors now dance in variables so bright.
Shadows, hovers, and splits, all set with flair,
A new theme blossoms gentle as fresh spring air.
In a code garden, I nibble on this stylish bite.
Happy hops to changes that feel just right!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fd8b3a7 and add639e.

📒 Files selected for processing (2)

• packages/theme/src/crop/index.less (3 hunks)
• packages/theme/src/crop/vars.less (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• packages/theme/src/crop/index.less
• packages/theme/src/crop/vars.less

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

packages/theme/src/crop/index.less (1)

325-334: Usage of CSS Variables for Dialog Handle Styling
The updated block for &__dialog-content__handle now leverages CSS variables for both the background and box-shadow. This aligns well with the theme customization objectives. Consider adding fallback values (using the CSS syntax var(--variable, fallback)) if there is any risk that these variables might not be defined.

packages/theme/src/crop/vars.less (1)

20-29: Introduction of New CSS Custom Properties
The new custom properties for the crop component (background, font, hover, box-shadow, and split background) are well defined and logically assigned. This change greatly enhances the maintainability and flexibility of the theme. One minor suggestion: the comment on line 28 appears to repeat "条框的阴影" similarly to line 26, whereas it might be clearer if the comment for line 29 specifies that it defines the split background color (e.g., "条框分割背景颜色") to avoid ambiguity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e04d727 and fd8b3a7.

📒 Files selected for processing (2)

• packages/theme/src/crop/index.less (3 hunks)
• packages/theme/src/crop/vars.less (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (3)

packages/theme/src/crop/index.less (3)

342-347: Icon Button Fill Color via CSS Variable
The change to use var(--tv-Crop-select-font-color) for the fill property in the .iconButtonset block is consistent with the new theming approach and improves maintainability.

---

352-354: Hover Background Update with CSS Variable
Updating the hover effect background color to use var(--tv-Crop-select-icon-hover-color) ensures a more dynamic and theme-consistent interaction state for the icons.

---

357-362: Icon Button Split Background Color Adjustment
The background color for .iconButton__split is now driven by var(--tv-Crop-select-box-split-bg-color), which is in line with the overall shift to CSS variables. The implementation is clear and consistent.