-
Notifications
You must be signed in to change notification settings - Fork 298
feat: Add utils test commands and add utils package change check in CI #3327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes introduce targeted unit testing for the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/utils/src/type/__tests__/type.test.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/test-unit-pr.yml (1)
19-21
: Update GitHub Action version.The runner for "actions/checkout@v3" is flagged as being too old for GitHub Actions.
Consider updating to a newer version:
- - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0🧰 Tools
🪛 actionlint (1.7.4)
19-19: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/test-unit-pr.yml
(4 hunks)package.json
(1 hunks)packages/utils/src/type/__tests__/type.test.ts
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/utils/src/type/__tests__/type.test.ts (1)
packages/utils/src/type/index.ts (1)
isNull
(72-72)
🪛 actionlint (1.7.4)
.github/workflows/test-unit-pr.yml
19-19: the runner of "actions/checkout@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (6)
package.json (1)
89-89
: LGTM! Test script added for utils package.This new script allows for targeted testing of the utils package, which is now used in the CI workflow to run tests only when changes are detected in the utils package.
.github/workflows/test-unit-pr.yml (5)
17-17
: LGTM! Added output for utils package changes.The new
utilsModified
output variable in theparse-components
job allows subsequent jobs to conditionally run utils package tests.
49-68
: LGTM! Well-implemented detection of utils package changes.This script properly detects changes in the utils package by comparing the current PR branch with the base branch. The clear comments explain the logic, and the output variable is set correctly to inform downstream jobs.
99-99
: LGTM! Added environment variable for utils changes.This environment variable correctly references the output from the previous job to make it available in the current job's steps.
125-127
: LGTM! Renamed step for clarity.Renaming this step to "Unit Test for Components" provides better clarity about its purpose, especially now that there's a separate step for utils tests.
129-131
: LGTM! Added conditional utils unit test step.This new step properly runs the utils tests only when changes are detected in the utils package, making the CI process more efficient.
feat: 增加utils测试命令并在CI中添加utils包变更检查
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes