Support Hijack on Status Code Tracker #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface converssions at other layers continue to work as expected
|
We ran into a similar issue in our internal instrumentation library and decided to go with github.com/felixge/httpsnoop that allows a whole set of interfaces and using different structs for each unique combination. |
|
oh sweet, yeah https://github.com/felixge/httpsnoop looks like a better way to do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach to #7
Instead of returning an error, wrap the response in two different structs, one that has Hijack, and one that doesn't. This doesn't scale well if there are more optional interfaces to support, but Hijack is the primary one seen in the wild for ResponseWriters....
I wish it was a little cleaner, but didn't see many other ways to do it.