Use storybook-react-intl addon#355
Merged
binh-dam-ibigroup merged 15 commits intoopentripplanner:masterfrom Mar 14, 2022
Merged
Use storybook-react-intl addon#355binh-dam-ibigroup merged 15 commits intoopentripplanner:masterfrom
binh-dam-ibigroup merged 15 commits intoopentripplanner:masterfrom
Conversation
Collaborator
Author
|
This is ready for review now. |
This was referenced Mar 3, 2022
Merged
Merged
miles-grant-ibigroup
approved these changes
Mar 3, 2022
Collaborator
miles-grant-ibigroup
left a comment
miles-grant-ibigroup
left a comment
There was a problem hiding this comment.
Well done getting this added so seamlessly! Thanks also for cleaning up the snapshots now. Looks much better.
I have a few quick questions about some small details
daniel-heppner-ibigroup
approved these changes
Mar 11, 2022
Contributor
daniel-heppner-ibigroup
left a comment
daniel-heppner-ibigroup
left a comment
There was a problem hiding this comment.
Looks great! Feels very proper.
| const intlDecorator = (Story: StoryType): ReactElement => ( | ||
| <IntlProvider locale="en-US" messages={flatten(englishMessages)}> | ||
| const decorator = (Story: StoryType): ReactElement => ( | ||
| <div> |
Contributor
There was a problem hiding this comment.
Is a surrounding div necessary? Would <> work?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will avoid the extra boiler plate code to load messages and provide an
<IntlProvider>wrapper for each component.As a result,