Repository navigation
[TEMP][DO NOT REVIEW] Isolate PR 11685 mtype topology state - #11864
jeffnvidia wants to merge 16 commits into
Conversation
|
🤖 Starting review — findings will be posted here when done. |
| min_msg_length = thresh->max_msg_length + 1; | ||
| ++thresh; | ||
| } | ||
| } |
There was a problem hiding this comment.
blocker: leftover PR11685_DIAG debugging output. The entire dump_am_rndv_selection() function (lines 403-479) only emits UCS_TEST_MESSAGE << "PR11685_DIAG ..." diagnostics. This is leftover debug instrumentation: it spams verbose messages on every call (used by all three test_ucp_proto_am_rndv tests), and the tag PR11685_DIAG references the wrong PR (this is #11864). Please remove dump_am_rndv_selection() before merge.
| return nullptr; | ||
| } | ||
|
|
||
| dump_am_rndv_selection(select_elem); |
There was a problem hiding this comment.
blocker: dump_am_rndv_selection() is unconditionally invoked here from select_am_rndv_remote_proto_config(). Remove this call site along with the debugging function.
| "RNDV_PIPELINE_SHM_CUDA_STAGING_FORCE=y", | ||
| "RNDV_SCHEME=get_zcopy") | ||
| "RNDV_SCHEME=get_zcopy", | ||
| "PROTO_INFO=y") |
There was a problem hiding this comment.
blocker: the paired "PROTO_INFO=y" config added to am_explicit_scheme_disables_force_provenance makes the test dump full protocol-selection info to a directory. This is debugging-only leftover; please remove it before merge.
| "IB_NUM_PATHS?=1", "RNDV_SCHEME=put_zcopy") | ||
| { | ||
| constexpr size_t select_size = UCS_MBYTE; | ||
| uint8_t remote = 0; |
There was a problem hiding this comment.
Non-blocking: in set_frag_sys_dev(), md_index and mem_info are written by ucp_mm_get_alloc_md_index() but never read afterwards (the function directly overwrites alloc_md[...].sys_dev). This may trigger -Wunused-but-set-variable. Consider passing throwaway locals with UCS_V_UNUSED or documenting that only the side effect matters.
| * protocol. | ||
| */ | ||
| mem_info.sys_dev = init_params->rkey_config_key->sys_dev; | ||
| mem_info.sys_dev = UCS_SYS_DEVICE_ID_UNKNOWN; |
There was a problem hiding this comment.
Non-blocking: flipping mem_info.sys_dev to UCS_SYS_DEVICE_ID_UNKNOWN in ucp_proto_rndv_remote_select_param_init aligns with the assertion in ucp_proto_common_get_lane_perf (sys_dev == select_param->sys_dev for SEND_ZCOPY), and the mtype prepare keeps them consistent for the local side. No correctness issue found.
83de702 to
6eb6bb5
Compare
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 Review complete — no issues found. |
|
🤖 CI Triage Agent — TL;DR: The only failing test, Full analysisSummary: gtest run on "roce on worker 3" ended with Root cause: The test asserts that a remote peer's process-local ( But the current production code copies the rkey's sys_dev straight into the remote select param: so Implicated commit: File: Suggested fix: Re-apply the Related: PR #11685 "UCP/PROTO/RNDV: Isolate remote system device namespace" (#11685); this build is PR #11864 (branch |
Diagnostic companion to #11685 and #11861.
This keeps the PR 11685 production changes and all of its tests. It changes only test_ucp_proto_mock_mtype_sys_dev to snapshot and restore the process-global topology registry, following the existing neighboring NUMA mock fixture pattern. Existing PR11685_DIAG instrumentation is retained.
Purpose: distinguish mtype-fixture topology leakage from a production protocol-selection regression. Do not review or merge.