Repository navigation
UCP: Reject max eager, rndv and RMA rails above UCP_MAX_LANES - #12068
Conversation
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 CI Triage Agent — TL;DR: Not a code regression from PR #12068 — the Full analysisSummary: Root cause: Hardware/driver-level failure on device Evidence chain from the log:
Why this is unrelated to the PR: commit Secondary code-level weakness worth fixing: Implicated commit: none — File: Suggested fix:
Related: PR #12068 (
|
|
can you implement some uint test pls? |
Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
|
🤖 Starting review — findings will be posted here when done. |
@brminich Added unit tests. |
|
🤖 Starting review — findings will be posted here when done. |
What?
ucp_init()withUCS_ERR_INVALID_PARAMwhenUCX_MAX_EAGER_RAILS,UCX_MAX_RNDV_RAILSorUCX_MAX_RMA_RAILSexceedsUCP_MAX_LANES(64).uint8_t.Why?
The code already assumes at most
UCP_MAX_LANESrails: the protocol layer stores the value in an 8-bit field and asserts it is at mostUCP_PROTO_MAX_LANES, so larger values were never usable.Rejecting them at init makes that limit explicit, and lets the per-device lane counters in
ucp_wireup_add_bw_lanes_pairwise()shrink touint8_t, this saves lots of stack space especially after #12054 is merged.