Skip to content

GTEST: Restore and check the current CUDA device after each test - v1.23.x - #12189

Merged
ofirfarjun7 merged 1 commit into
openucx:v1.23.xfrom
amastbaum:backport_12073
Oct 29, 2026
Merged

ofirfarjun7 merged 1 commit into
openucx:v1.23.xfrom
amastbaum:backport_12073

Conversation

@amastbaum

Copy link
Copy Markdown
Contributor

What?

backport #12073

…nucx#12073)

* GTEST/UCT/CUDA: Restore the current device after each test

Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>

* GTEST: Restore and check the current CUDA device after each test

Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>

* GTEST: Code cleanup

Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>

---------

Signed-off-by: Guy Ealey Morag <gealeymorag@nvidia.com>
@svc-nvidia-pr-review

Copy link
Copy Markdown

🤖 Starting review — findings will be posted here when done.

@amastbaum
amastbaum requested a review from ofirfarjun7 October 28, 2026 10:59
@amastbaum
amastbaum marked this pull request as ready for review October 28, 2026 11:00
@ofirfarjun7
ofirfarjun7 enabled auto-merge (squash) October 28, 2026 11:01
Comment thread test/gtest/common/test.cc Resolved
@svc-nvidia-pr-review

Copy link
Copy Markdown

Residual coverage gap worth noting (not blocking, matches stated intent): the new TearDownProxy() check only fires on CUDA builds with at least one device, and only for the main thread — a device left current by a test's worker thread is still not detected.

@rakhmets rakhmets changed the title GTEST: Restore and check the current CUDA device after each test (#12… GTEST: Restore and check the current CUDA device after each test - v1.23.x Oct 28, 2026
@ofirfarjun7
ofirfarjun7 merged commit bc0c8ad into openucx:v1.23.x Oct 29, 2026
162 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants