Repository navigation
UCP/RMA: Share SGL multi-lane send code in proto_multi.inl - #12226
Conversation
|
🤖 Starting review — findings will be posted here when done. |
|
Residual gap: no gtest exercises a Residual gap: SGL zcopy offload ( |
|
🤖 CI Triage Agent — TL;DR: The gtest binary aborted on a UCS rcache assertion ( Full analysisSummary: Root cause: Registration-cache reference-count underflow. A region inserted into the rcache page table is created with Implicated commit: File: Suggested fix:
Related: PR #12226 (this PR), #12191 (UCP/RMA: Add SGL support to
|
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 CI Triage Agent — TL;DR: The gtest run failed on a single unrelated test, Full analysisSummary: Root cause: From the log, 9036/9037 tests passed; the only failure is A real contributing defect in the test: Implicated commit: unknown — not attributable to [REDACTED:Hex High Entropy String] (PR #12226); recent commits touching File: test/gtest/uct/test_md.cc:559 (check), test/gtest/uct/test_md.cc:484 (counter init), test/gtest/uct/test_md.cc:516 (per-mem-type loop) Suggested fix:
Related: PR #12226 (the PR under test, #12226); no existing issue found for
|
What?
Move the PUT SGL fragment/batch send code into shared helpers in
proto_multi.inl, and reuse them in the PUT sw protocol.Why?
Prepare for GET SGL, which needs the same lane split. No functional change.