Repository navigation
CI: Trigger Blossom CI automatically on PR events - #12235
Alexey-Rivkin wants to merge 2 commits into
Conversation
Blossom CI only starts on a "/build" comment, so every PR needs a manual step before Jenkins runs. Add a pull_request_target trigger so it starts on PR open, update and reopen. Blossom AUTH still gates who may run it; Vulnerability-scan is skipped when AUTH returns no args. The workflow matches the version NIXL runs, which Blossom accepts. Jenkins checks stay non-mandatory: the only required check on master is "UCX PR". Signed-off-by: Alexey Rivkin <arivkin@nvidia.com>
|
🤖 Starting review — findings will be posted here when done. |
|
Suggested review mode: COMMENT. The main security concern ( Residual gap: no CI evidence in-repo that the new trigger behaves as intended; validation must come from a fork run or Residual gap: |
|
🤖 CI Triage Agent — TL;DR: The ASAN GPU shard didn't fail an assertion — it hung: Full analysisSummary: Root cause: A hang, not a slow test. Timestamp analysis of the stage log:
So UCX progress was being driven continuously but the rendezvous PUT request never completed and no transport error was reported — a lost completion / stalled rendezvous handshake (RTS→RTR→PUT→ATP), not a time-limit problem. The test configuration is the unusual part: Note the ASAN job does not export Implicated commit: unknown (no UCX trace in the log). Recent commits touching exactly this path, in order of suspicion: File: Suggested fix:
Related: PR #11062 ("UCP/RNDV: Throttle rndv fragment requests", merged as
|
With Blossom CI starting on every push, the dispatcher also receives PR push payloads, which carry the PR number at the top level rather than in issue.number as /build comments do. The stale-run filter only read issue.number, so a push never matched the previous run and left it and its leaf jobs running alongside the new one. Signed-off-by: Alexey Rivkin <arivkin@nvidia.com>
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 CI Triage Agent — TL;DR: The ASAN gtest shard was killed because its very first test, Full analysisSummary: Root cause: Log timestamps show the test started at
Implicated commit: unknown — the tested commit File: Suggested fix:
Related: #11845, #11847 (AH cache changes in the DC send path); #12235 (the CI-only PR under test) |
What?
Start Blossom CI (Jenkins) automatically on PR open/update/reopen, no
/buildcomment needed.Why?
Today every PR needs a manual
/buildcomment before Jenkins runs.How?
pull_request_targettrigger (opened, synchronize, reopened) and letAuthorizationrun on itVulnerability-scanwhenAuthorizationreturns no argscontents,pull-requests,statusesset towritenumber), as CI: handle PR push payloads in the dispatcher ai-dynamo/nixl#2595 does; otherwise each push leaves the previous run goingUCX PR(Azure)