Repository navigation
TEST/UCP: Add operation variant to RMA SGL tests - #12277
Conversation
|
🤖 Starting review — findings will be posted here when done. |
|
Residual coverage gap worth noting: with only the |
|
🤖 Starting review — findings will be posted here when done. |
|
Residual gap (already raised previously, no new thread needed): the
Noted but minor: the |
|
🤖 Starting review — findings will be posted here when done. |
|
minor: in this class
Residual coverage gap (previously raised): |
|
🤖 Starting review — findings will be posted here when done. |
|
🤖 Starting review — findings will be posted here when done. |
|
The |
|
🤖 CI Triage Agent — TL;DR: The only failing test is Full analysisSummary: Root cause: The failing test is the only one in the run that allocates a Implicated commit: Not the PR commit (8ee49ad). The fragile retry-then-assert logic comes from 69718f6 / [REDACTED:Hex High Entropy String] (Michal Shalev), on top of 6c7715d (Roie Danino, added the test). File: test/gtest/uct/test_atomic_key_reg_rdma_mem_type.cc:33 (and test/gtest/uct/uct_test.cc:1035 — Suggested fix: Re-trigger the job — this failure is environmental and not caused by the PR. To stop the recurring flake, make RDMA/MEMIC allocation failure a skip instead of a hard failure: add an optional "allow failure" mode to Related: #10475 (increase retries + random sleep on MEMIC allocation failure), #12277 (the PR under test — unrelated to the failure)
|
| /* Parameter validation tests do not depend on the memory type, so they | ||
| * run with a single memory type for both source and destination */ |
There was a problem hiding this comment.
nit: the comment still sits above get_test_variants(), which now only adds the put/get op variant; it describes get_memtype_variants(), so could you move it one function up?
| * run with a single memory type for both source and destination */ | ||
| static void get_test_variants(std::vector<ucp_test_variant>& variants) { | ||
| add_variant_memtypes(variants, get_base_variants, SGL_MEM_TYPES_MASK); | ||
| static const char *op_names[] = {"put", "get"}; |
There was a problem hiding this comment.
maybe it worth removing "get" from here?
There was a problem hiding this comment.
Why? This PR is preparation for GET SGL support
There was a problem hiding this comment.
but you have only UCS_BIT(SGL_OP_PUT), so "get" will be never reached, but you can ignore
|
🤖 Starting review — findings will be posted here when done. |
|
minor: these positional variant indexes are easy to break — adding the op dimension silently moved the dst memory type from index 2 to 3 (
The get variant is not instantiated (
The
The naming overlap between
Residual coverage gap: nothing in this change is exercised for get, so the swapped-buffer logic, the |
What?
Make the RMA SGL gtests take the operation from a test variant instead of a parameter.
Only PUT is enabled.
Why?
Prep for GET SGL support, which will add the GET variant.
No change in coverage.