Skip to content

UCP/GTEST: initialization of the ucp layer. and a test in gtest for testing it. - #61

Merged
yosefe merged 4 commits into
openucx:masterfrom
alinask:topic/initial-ucp
Dec 25, 2014
Merged

yosefe merged 4 commits into
openucx:masterfrom
alinask:topic/initial-ucp

Conversation

@alinask

@alinask alinask commented Dec 23, 2014

Copy link
Copy Markdown
Contributor

No description provided.

@alinask

alinask commented Dec 23, 2014

Copy link
Copy Markdown
Contributor Author

@yosefe please review

@mellanox-github

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/118/

Build Log
last 50 lines

[...truncated 540 lines...]
  CC       tl/libuct_la-context.lo
  CC       tl/libuct_la-tl_base.lo
  CC       ib/base/libuct_la-ib_context.lo
  CC       ib/base/libuct_la-ib_device.lo
  CC       ib/base/libuct_la-ib_iface.lo
  CC       ib/mlx5/libuct_la-ib_mlx5.lo
  CC       ib/rc/libuct_la-rc_ep.lo
  CC       ib/rc/libuct_la-rc_iface.lo
  CC       ib/rc/libuct_la-rc_verbs_ep.lo
  CC       ib/rc/libuct_la-rc_verbs_iface.lo
  CC       ib/rc/libuct_la-rc_mlx5_ep.lo
  CC       ib/rc/libuct_la-rc_mlx5_iface.lo
  CCLD     libuct.la
make[2]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test/src/uct'
Making all in src/ucp
make[2]: Entering directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test/src/ucp'
  CC       libucp_la-ucp.lo
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:8:29: error: src/ucp/api/ucp.h: No such file or directory
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:15: error: expected ')' before '*' token
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:55: error: expected ')' before 'context_p'
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:62: error: expected ')' before 'ucp_context'
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:102: error: expected ')' before 'ucp_iface'
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:108: error: expected ')' before 'ucp_iface'
/scrap/jenkins/jobs/gh-ucx-pr/workspace/contrib/../src/ucp/ucp.c:133: error: expected ')' before 'ucp_ep'
make[2]: *** [libucp_la-ucp.lo] Error 1
make[2]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test/src/ucp'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/scrap/jenkins/jobs/gh-ucx-pr/workspace/build-test'
make: *** [all] Error 2
+ echo 'Running ucx_info'
Running ucx_info
+ ./src/tools/info/ucx_info -v -f
./contrib/test_jenkins.sh: line 31: ./src/tools/info/ucx_info: No such file or directory
Build step 'Execute shell' marked build as failure
TAP Reports Processing: START
Looking for TAP results report in workspace using pattern: **/*.tap
Did not find any matching files.
[Valgrind] Files to copy:
[Valgrind] Analysing valgrind results
[Valgrind] Ending the valgrind analysis.
Anchor chain: could not read file with links: /var/lib/jenkins/jobs/gh-ucx-pr/workspace/**/jenkins_sidelinks.txt (No such file or directory)
[copy-to-slave] The build is taking place on the master node, no copy back to the master will take place.
Email was triggered for: Failure - Any
Sending email for trigger: Failure - Any
Request made to compress build log
Sending email to: eugene@mellanox.com miked@mellanox.com yosefe@mellanox.com
[BFA] Scanning build for known causes...

[BFA] Done. 0s

Test FAILed.

@mellanox-github

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/119/
Test PASSed.

Comment thread src/ucp/Makefile.am Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for ORNL copyright here (sorry Pasha:wink:)
The rule is copyright is added for each organization which modifies a file.

@mellanox-github

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/120/
Test PASSed.

Comment thread src/ucp/ucp.c Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for \n

@shamisp

shamisp commented Dec 24, 2014

Copy link
Copy Markdown
Contributor

👍

Comment thread src/ucp/Makefile.am

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noinst_HEADERS can replace nobase_dist_libucp_la_HEADERS

@mellanox-github

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
http://bgate.mellanox.com:8000/jenkins-secure/job/gh-ucx-pr/124/
Test PASSed.

@yosefe

yosefe commented Dec 25, 2014

Copy link
Copy Markdown
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants