Skip to content

Remove myriad plugin #15131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 18, 2023
Merged

Remove myriad plugin #15131

merged 22 commits into from
Jan 18, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

Details:

@ilya-lavrenov ilya-lavrenov added this to the 2023.0 milestone Jan 16, 2023
@ilya-lavrenov ilya-lavrenov requested review from a team as code owners January 16, 2023 07:40
Wovchena
Wovchena reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Wovchena Wovchena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I remove MYRIAD and HDDL mentions from OMZ?

DariaMityagina
DariaMityagina reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@DariaMityagina DariaMityagina left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still mentions and uses of myriad in different files (.ci, docs, src/inference/include/ie/vpu/, src/inference/include/openvino/runtime/intel_myriad/ and other folders).
Is this intentional?

@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Jan 16, 2023 •
edited
Loading

Is this intentional?

Yes, we have mentioning:

  • public header files: we cannot remove them instantly. We have to deprecate API first
  • several places in documentation: needs to be rewritten by docs team

wangleis
wangleis reviewed Jan 17, 2023
View reviewed changes
src/tests/unit/auto/auto_select_device_failed_test.cpp Outdated
@@ -275,28 +275,20 @@ TEST_P(AutoLoadFailedTest, LoadCNNetWork) {
// so inference request num is 4 (CPU 2, MYRIAD 2)
//
const std::vector<ConfigParams> testConfigs = {ConfigParams {true, false, GENERAL, {DeviceParams {CommonTestUtils::DEVICE_GPU, true},
DeviceParams {"MYRIAD", true},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticket 101367 is created to follow up any Myriad/HDDL related change in AUTO/MULTI

xu-yuan1
xu-yuan1 reviewed Jan 17, 2023
View reviewed changes
xu-yuan1
xu-yuan1 reviewed Jan 17, 2023
View reviewed changes
xu-yuan1
xu-yuan1 reviewed Jan 17, 2023
View reviewed changes
@xu-yuan1
Copy link
Contributor

Added a few comments. Looks good to me, thanks! :)

kblaszczak-intel
kblaszczak-intel approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@kblaszczak-intel kblaszczak-intel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to block the PR so I think it should be merged. Still, so many documentation articles are included here that we need to check if these deletions don't require other corrections. We'll do it in other PRs if necessary.

@ilya-lavrenov
Copy link
Contributor Author

Hi @kblaszczak-intel,

Still, so many documentation articles are included here that we need to check if these deletions don't require other corrections. We'll do it in other PRs if necessary.

Documentation changes are enclosed in commit 03995f4, which is reviewed by @xu-yuan1. However, we still have several places in the docs, where docs team need to remove MYRIAD, NCS2, HDDL wordings, because I have touched only more or less simple cases. I will create a ticket not to forget.

@kblaszczak-intel
Copy link
Contributor

@ilya-lavrenov Great, we'll do a followup and remove whatever's necessary.

@ilya-lavrenov ilya-lavrenov merged commit c4eeecf into openvinotoolkit:master Jan 18, 2023
@ilya-lavrenov ilya-lavrenov deleted the remove-myriad-plugin branch January 18, 2023 11:19
@Maxim-Doronin
Copy link
Contributor

Approved from my side as well. Thanks for contributing!

@ilya-lavrenov
Copy link
Contributor Author

Approved from my side as well. Thanks for contributing!

Always glad to remove something 💇

e-nugmanova pushed a commit to e-nugmanova/openvino that referenced this pull request Jan 19, 2023
@ilya-lavrenov @xu-yuan1
Remove myriad plugin (openvinotoolkit#15131)
1e1a8d2 
* Removed Intel MYRIAD plugin

* Removed Intel MYIAD from CI files

* Removed Intel MYRIAD from cmake folder

* Removed MYRIAD, HDDL from samples

* Removed MYRIAD, HDDL from scripts folder

* Removed MYRIAD from bindings folder (C and Python API)

* Removed MYRIAD tests

* Removed MYRIAD from tests folder

* Removed MYRIAD from tools folder

* Removed HDDL (VAD), MYRIAD (NSC2) from documentation

* Fixed build for AUTO unit tests

* Fixed clang code style

* Fixed comments and issues

* removed MYRIAD from AUTO tests

* Disabled MULTI tests in CI

* Update docs/OV_Runtime_UG/auto_device_selection.md

Co-authored-by: Yuan Xu <[email protected]>

* Update docs/get_started/get_started_demos.md

Co-authored-by: Yuan Xu <[email protected]>

* Update docs/OV_Runtime_UG/deployment/local-distribution.md

Co-authored-by: Yuan Xu <[email protected]>

Co-authored-by: Yuan Xu <[email protected]>
@peterchen-intel peterchen-intel mentioned this pull request Feb 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangleis wangleis wangleis left review comments

@Wovchena Wovchena Wovchena approved these changes

@akuporos akuporos akuporos approved these changes

@DariaMityagina DariaMityagina DariaMityagina approved these changes

@kblaszczak-intel kblaszczak-intel kblaszczak-intel approved these changes

@xu-yuan1 xu-yuan1 xu-yuan1 approved these changes

@ilyachur ilyachur Awaiting requested review from ilyachur ilyachur is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@tomdol tomdol Awaiting requested review from tomdol tomdol is a code owner automatically assigned from openvinotoolkit/openvino-maintainers

@artanokhov artanokhov Awaiting requested review from artanokhov artanokhov is a code owner automatically assigned from openvinotoolkit/openvino-configuration-mgmt

Assignees

@Maxim-Doronin Maxim-Doronin

Labels
category: AUTO OpenVINO AUTO device selection plugin category: build OpenVINO cmake script / infra category: C API OpenVINO C API bindings category: CI OpenVINO public CI category: CPP API OpenVINO CPP API bindings category: CPU OpenVINO CPU plugin category: dependency_changes Pull requests that update a dependency file category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference category: packaging OpenVINO packaging / distribution category: Python API OpenVINO Python bindings category: samples OpenVINO Runtime Samples category: tools OpenVINO C++ / Python tools
Projects
None yet
Milestone
2023.0
Development

Successfully merging this pull request may close these issues.
8 participants
@ilya-lavrenov @xu-yuan1 @kblaszczak-intel @Maxim-Doronin @Wovchena @wangleis @akuporos @DariaMityagina