Skip to content

Conversation

@DannyVlasenko
Copy link
Contributor

@DannyVlasenko DannyVlasenko commented May 1, 2024

Check for a batch size in the model validation pass and a notification message with information about wrong values.
fixes #24243

Details:

  • Implement protection for BS=0 in the validation pass of a model to address this problem for all devices
  • Added unit tests for BS=0

Tickets:

  • 24243

…a notification message with information about wrong values.
@DannyVlasenko DannyVlasenko requested a review from a team as a code owner May 1, 2024 22:55
@github-actions github-actions bot added the category: inference OpenVINO Runtime library - Inference label May 1, 2024
@sys-openvino-ci sys-openvino-ci added the ExternalPR External contributor label May 1, 2024
@DannyVlasenko DannyVlasenko changed the title Check for a batch size in the ICompiledModel constructor Check for a batch size in the ICompiledModel constructor fixes #24243 May 2, 2024
@DannyVlasenko DannyVlasenko changed the title Check for a batch size in the ICompiledModel constructor fixes #24243 Check for a batch size in the ICompiledModel constructor May 2, 2024
… to do the actual check only if there is a layout on a parameter that allows to locate BS.
@ilya-lavrenov
Copy link
Contributor

build_jenkins

@riverlijunjie
Copy link
Contributor

build_jenkins

@DannyVlasenko DannyVlasenko requested a review from a team as a code owner May 22, 2024 07:59
@github-actions github-actions bot added the category: Core OpenVINO Core (aka ngraph) label May 22, 2024
@DannyVlasenko DannyVlasenko force-pushed the 24243_trap_divide_error_in_GPU_plugin_for_batch_size_0 branch from d2f95f8 to 956d7cd Compare May 22, 2024 08:06
@github-actions github-actions bot removed the category: inference OpenVINO Runtime library - Inference label May 22, 2024
…structor to the validation pass of model, namely to the validate_nodes_and_infer_types() function
@DannyVlasenko DannyVlasenko force-pushed the 24243_trap_divide_error_in_GPU_plugin_for_batch_size_0 branch from 956d7cd to 12d5f11 Compare May 22, 2024 08:20
@DannyVlasenko DannyVlasenko changed the title Check for a batch size in the ICompiledModel constructor Check for a batch size in the model validation pass May 22, 2024
@riverlijunjie
Copy link
Contributor

build_jenkins

@riverlijunjie
Copy link
Contributor

build_jenkins

@ilya-lavrenov ilya-lavrenov added this to the 2024.3 milestone May 27, 2024
@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Jun 30, 2024
@mlukasze mlukasze reopened this Jul 1, 2024
@mlukasze
Copy link
Contributor

mlukasze commented Jul 1, 2024

build_jenkins

@mlukasze mlukasze enabled auto-merge July 1, 2024 05:13
@github-actions github-actions bot removed the Stale label Jul 3, 2024
@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Jul 17, 2024
@github-actions github-actions bot removed the Stale label Jul 18, 2024
@mlukasze mlukasze modified the milestones: 2024.3, 2024.4 Jul 25, 2024
@mlukasze
Copy link
Contributor

build_jenkins

@github-actions
Copy link
Contributor

This PR will be closed in a week because of 2 weeks of no activity.

@github-actions github-actions bot added the Stale label Aug 14, 2024
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 2 week with no activity.

@github-actions github-actions bot closed this Aug 22, 2024
auto-merge was automatically disabled August 22, 2024 00:20

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: Core OpenVINO Core (aka ngraph) ExternalPR External contributor Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Trap divide error in GPU plugin for batch size 0

8 participants