[GPU] Support fsv16 Shape agnostic convolution. #25020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyunback
force-pushed
the
sa_conv_fsv16_poc
branch
3 times, most recently
from
36192b8 to
d5da6d5
Compare
Signed-off-by: hyunback <[email protected]>
Find the root cause and fixing.. Signed-off-by: hyunback <[email protected]>
Signed-off-by: hyunback <[email protected]>
Signed-off-by: hyunback <[email protected]>
hyunback
force-pushed
the
sa_conv_fsv16_poc
branch
from
d5da6d5 to
01e85b5
Compare
Signed-off-by: hyunback <[email protected]>
Signed-off-by: hyunback <[email protected]>
hyunback
force-pushed
the
sa_conv_fsv16_poc
branch
2 times, most recently
from
1100ab5 to
f3fa3d3
Compare
e-ddykim
reviewed
Jun 24, 2024
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Show resolved
Hide resolved
Signed-off-by: hyunback <[email protected]>
e-ddykim
reviewed
Jun 24, 2024
src/plugins/intel_gpu/src/graph/graph_optimizer/compile_graph.cpp
Outdated
Show resolved
Hide resolved
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Outdated
Show resolved
Hide resolved
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Outdated
Show resolved
Hide resolved
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: hyunback <[email protected]>
Signed-off-by: hyunback <[email protected]>
Signed-off-by: hyunback <[email protected]>
e-ddykim
approved these changes
Jun 26, 2024
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Outdated
Show resolved
Hide resolved
...s/intel_gpu/src/kernel_selector/kernels/convolution/convolution_kernel_b_fs_yx_fsv16_1x1.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: hyunback <[email protected]>
sshlyapn
reviewed
Jun 26, 2024
Comment on lines
443
to
445
| kd.internalBufferSizes.clear(); | ||
| kd.internalBufferSizes.push_back(prim_params.inputs[0].PhysicalSizeInBytes()); | ||
| kd.internalBufferDataType = prim_params.inputs[0].GetDType(); |
Contributor
There was a problem hiding this comment.
Why do we need this internal buffer?
Contributor
Author
There was a problem hiding this comment.
Applied, frankly no need, it came from convolution_kernel_base.
Signed-off-by: hyunback <[email protected]>
yeonbok
approved these changes
Jun 28, 2024
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
### Details: - Stable Diffusion in dpas has bad first inference latency because all onednn convolutions are compiled at first inference. We can resolve this bottleneck with shape agnostic kernel. Target kernel is convolution_fsv16_1x1 ### Tickets: - *143317* --------- Signed-off-by: hyunback <[email protected]>
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
### Details: - Stable Diffusion in dpas has bad first inference latency because all onednn convolutions are compiled at first inference. We can resolve this bottleneck with shape agnostic kernel. Target kernel is convolution_fsv16_1x1 ### Tickets: - *143317* --------- Signed-off-by: hyunback <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: