[PT FE] Support setting types/shapes for nested structures #25064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: MO
rkazants
reviewed
Jun 17, 2024
rkazants
reviewed
Jun 17, 2024
rkazants
reviewed
Jun 17, 2024
github-actions
bot
added
category: ONNX FE
mvafin
commented
Jun 18, 2024
mvafin
commented
Jun 18, 2024
popovaan
reviewed
Jun 18, 2024
popovaan
approved these changes
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
mvafin
commented
Jun 27, 2024
Comment on lines
+76
to
+82
| enabled_transforms, disabled_transforms = get_enabled_and_disabled_transforms() | ||
| if 'ANALYSIS_JSON_PRINT' in enabled_transforms: | ||
| # NOTE that model analysis is performed before applying user's settings (inputs's shapes etc.) | ||
| framework_model = moc_front_end.decode(input_model) | ||
| json_model_analysis_dump(framework_model) | ||
| # a model is not processed further in json analysis mode | ||
| sys.exit(0) |
Contributor
Author
There was a problem hiding this comment.
It was moved unchanged. To preserve behavior and avoid duplication
rkazants
reviewed
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
Collaborator
rkazants
left a comment
rkazants
left a comment
There was a problem hiding this comment.
please add only changes required for PyTorch and put it under separate if. No need to move helper functions to else
Contributor
Author
|
@rkazants I moved no helper functions |
rkazants
reviewed
Jun 27, 2024
rkazants
reviewed
Jun 27, 2024
rkazants
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
dicts,lists,tuplesas inputs. We unpack them onnormalizestep in PT FE, but this means that those unpacked inputs do not exist before conversion andconvert_modelcan't set shapes/types for them. This PR adds ability forconvert_modelto set shapes/types to any arbitrary input obtained by index or name.Tickets: