[Opset15][Spec] Add and update specifications for EmbeddingBag ops #25100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitruska
reviewed
Jun 21, 2024
...tation/openvino-ir-format/operation-sets/operation-specs/sparse/embedding-bag-offsets-15.rst
Outdated
Show resolved
Hide resolved
...ntation/openvino-ir-format/operation-sets/operation-specs/sparse/embedding-bag-packed-15.rst
Outdated
Show resolved
Hide resolved
| * **1**: ``emb_table`` tensor containing the embedding lookup table of the module of shape ``[num_emb, emb_dim1, emb_dim2, ...]`` and of type *T*. **Required.** | ||
| * **2**: ``indices`` tensor of shape ``[num_indices]`` and of type *T_IND*. **Required.** | ||
| * **3**: ``offsets`` tensor of shape ``[batch]`` and of type *T_IND* containing the starting index positions of each "bag" in ``indices``. Maximum value of offsets cannot be greater than length of ``indices``. **Required.** | ||
| * **4**: ``default_index`` scalar of type *T_IND* containing default index in embedding table to fill empty "bags". If set to ``-1`` or not provided, empty "bags" are filled with zeros. Reverse indexing using negative values is not supported. **Optional.** |
Contributor
There was a problem hiding this comment.
Usage of -1 is not an ideal solution, but as we discussed it's aligned with current behavior of some plugins and it resolves the empty bags issues. Although the main reason of adding v15 version was enablement of the "mean" mode, great to see the clarification of the default_index behavior as well.
mitruska
reviewed
Jun 27, 2024
...tation/openvino-ir-format/operation-sets/operation-specs/sparse/embedding-bag-offsets-15.rst
Show resolved
Hide resolved
…into mateuszm/emb/pack/spec
mitruska
approved these changes
Jun 27, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 28, 2024
…25100) ### Details: - *Add specification for EmbeddingBagOffsets-15 and EmbeddingBagPacked-15* - *Remove dead links and improve specification of EmbeddingBagOffsetsSum-3 and EmbeddingBagPackedSum-3* ### Tickets: - *141862* - *141863*
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…penvinotoolkit#25100) ### Details: - *Add specification for EmbeddingBagOffsets-15 and EmbeddingBagPacked-15* - *Remove dead links and improve specification of EmbeddingBagOffsetsSum-3 and EmbeddingBagPackedSum-3* ### Tickets: - *141862* - *141863*
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
…penvinotoolkit#25100) ### Details: - *Add specification for EmbeddingBagOffsets-15 and EmbeddingBagPacked-15* - *Remove dead links and improve specification of EmbeddingBagOffsetsSum-3 and EmbeddingBagPackedSum-3* ### Tickets: - *141862* - *141863*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: