Skip to content

fix cmake path issue #25251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DanLiu2Intel wants to merge 1 commit into from
Closed

fix cmake path issue #25251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmake/developer_package/api_validator/api_validator.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ can't find Windows SDK version. Try to use vcvarsall.bat script")
endif()
endif()

set(PROGRAMFILES_ENV "ProgramFiles\(X86\)")
set(PROGRAMFILES_ENV "ProgramFiles\(X86\)" PARENT_SCOPE)
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not used outside of this function, do we need to move to parent scope ?

What issue do you experience?

Copy link
Contributor Author

@DanLiu2Intel DanLiu2Intel Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, when build locally, can not find the UniversalDDIs.xml

[2024-06-26T21:58:25.848Z] CMake Error at cmake/developer_package/api_validator/api_validator.cmake:124 (message):
[2024-06-26T21:58:25.848Z]   Internal error: apiValidator is found (C:/Program Files (x86)/Windows
[2024-06-26T21:58:25.848Z]   Kits/10/bin/10.0.22621.0/x64/apivalidator.exe), but UniversalDDIs.xml file
[2024-06-26T21:58:25.848Z]   has not been found for x64 platform

by test locally, find the path is '/Windows Kits/10/build/10.0.19041.0/universalDDIs/x64/UniversalDDIs.xml'
${PROGRAMFILES_ENV} in here is used to search UniversalDDIs.xml.

    find_file(ONECORE_API_VALIDATOR_APIS NAMES UniversalDDIs.xml
              PATHS "${PROGRAMFILES}/Windows Kits/10/build/${CMAKE_VS_WINDOWS_TARGET_PLATFORM_VERSION}/universalDDIs/${wdk_platform}"
                    "${PROGRAMFILES}/Windows Kits/10/build/universalDDIs/${wdk_platform}"
              DOC "Path to UniversalDDIs.xml file")

Copy link
Contributor

@ilya-lavrenov ilya-lavrenov Jun 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI #25252


# check that PROGRAMFILES_ENV is defined, because in case of cross-compilation for Windows
# we don't have such variable
Expand Down