Skip to content

[pybind] Add float8 support in opset13 constant binding #25266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mlukasze merged 1 commit into from
Jun 28, 2024
Merged

[pybind] Add float8 support in opset13 constant binding #25266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bindings/python/src/openvino/runtime/opset13/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ def display_shared_memory_warning(warning_message: str) -> None:
if dtype in [Type.u1, Type.i4, Type.u4, Type.nf4, Type.f4e2m1]:
display_shared_memory_warning(f"Constant initialized with packed type of {dtype}")
return Constant(dtype, Shape(_value.shape), _value.flatten().tolist())
elif dtype in [Type.bf16]:
elif dtype in [Type.bf16, Type.f8e8m0, Type.f8e4m3, Type.f8e5m2]:
display_shared_memory_warning(f"Constant initialized with OpenVINO custom {dtype}")
return Constant(dtype, Shape(_value.shape), _value.flatten().tolist())
# General use-case for all other types:
Expand Down
100 changes: 58 additions & 42 deletions src/bindings/python/tests/test_graph/test_constant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
# SPDX-License-Identifier: Apache-2.0

import numpy as np
import openvino as ov

import openvino.runtime.opset13 as ops
from openvino import Type, PartialShape, Model, compile_model
Expand Down Expand Up @@ -413,13 +414,18 @@ def test_memory_sharing(shared_flag):
assert not np.shares_memory(arr, ov_const.data)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e5m2_constant(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
OPSETS = [ov.runtime.opset12, ov.runtime.opset13]


@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e5m2_constant(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, -5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, -0.1, -0.2, -0.3,
-0.4, -0.5, -0.6, -0.7, -0.8, -0.9, -1.0, 0.0000152587890625, 448, 500, 512, 57344], dtype=numpy_dtype)
Expand All @@ -443,13 +449,15 @@ def test_float_to_f8e5m2_constant(ov_type, numpy_dtype):
assert np.allclose(result, target)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e4m3_constant(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e4m3_constant(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, -5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, -0.1, -0.2, -0.3,
-0.4, -0.5, -0.6, -0.7, -0.8, -0.9, -1, 448, 512], dtype=numpy_dtype)
Expand All @@ -473,13 +481,15 @@ def test_float_to_f8e4m3_constant(ov_type, numpy_dtype):
assert np.allclose(result, target, equal_nan=True)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e8m0_constant(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e8m0_constant(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, 5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, 1.1, 1.2, 1.3,
1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 2.0, 448, 512, np.nan], dtype=numpy_dtype)
Expand All @@ -503,13 +513,15 @@ def test_float_to_f8e8m0_constant(ov_type, numpy_dtype):
assert np.allclose(result, target, equal_nan=True)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e5m2_convert(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e5m2_convert(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, -5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, -0.1, -0.2, -0.3,
-0.4, -0.5, -0.6, -0.7, -0.8, -0.9, -1.0, 0.0000152587890625, 448, 500, 512, 57344], dtype=numpy_dtype)
Expand All @@ -534,13 +546,15 @@ def test_float_to_f8e5m2_convert(ov_type, numpy_dtype):
assert np.allclose(result, target)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e4m3_convert(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e4m3_convert(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, -5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, -0.1, -0.2, -0.3,
-0.4, -0.5, -0.6, -0.7, -0.8, -0.9, -1, 448, 512], dtype=numpy_dtype)
Expand All @@ -565,13 +579,15 @@ def test_float_to_f8e4m3_convert(ov_type, numpy_dtype):
assert np.allclose(result, target, equal_nan=True)


@pytest.mark.parametrize(("ov_type", "numpy_dtype"), [
(Type.f32, np.float32),
(Type.f16, np.float16),
])
def test_float_to_f8e8m0_convert(ov_type, numpy_dtype):
from openvino.runtime import opset12 as opset
import openvino as ov
@pytest.mark.parametrize(("opset"), OPSETS)
@pytest.mark.parametrize(
("ov_type", "numpy_dtype"),
[
(Type.f32, np.float32),
(Type.f16, np.float16),
],
)
def test_float_to_f8e8m0_convert(ov_type, numpy_dtype, opset):
data = np.array([4.75, 4.5, 5.25, 0.0, 0.1, 0.2, 0.3, 0.4, 0.5,
0.6, 0.7, 0.8, 0.9, 1, -0.0, 1.1, 1.2, 1.3,
1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 2.0, 448, 512, np.nan], dtype=numpy_dtype)
Expand Down