[OV JS] Fix hardcoded error msg #25272
Merged
+13
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishniakov-nikolai
approved these changes
Jun 28, 2024
Co-authored-by: Vishniakov Nikolai <[email protected]>
praasz
reviewed
Jun 28, 2024
| }; | ||
|
|
||
| std::string get_parameters_error_msg(const Napi::CallbackInfo& info, std::vector<std::string>& allowed_signatures); | ||
| std::string get_parameters_error_msg(const Napi::CallbackInfo& info, |
Contributor
There was a problem hiding this comment.
Just to consider if this function is not to specialized instead build string for signatures it do more.
What if name is not required or there will be need something else.
Maybe leave this function unchanged to build signature string and use assert macro to build final message where required.
OPENVINO_THROW("Method 'my_method' called with invalid parameters\n", ov::js::get_parameters_signature_str(info, allowed_signatures));Macro build message with exact location (file, line), so maybe give method name is not required at all.
Contributor
Author
There was a problem hiding this comment.
The exact location points to C++ implementation of method that may have a different name in JS API.
Here it's readModelSync vs read_model_sync, but in some cases it might be quite confusing for a user.
vishniakov-nikolai
approved these changes
Jul 1, 2024
AsyaPronina
pushed a commit
to AsyaPronina/openvino
that referenced
this pull request
Jul 1, 2024
### Details: - Each error msg concerned the 'compiledModelSync' method. - A new parameter with method name was added to `get_parameters_error_msg` --------- Co-authored-by: Vishniakov Nikolai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
get_parameters_error_msg