[CPU] Refactor Infer update strategy #25404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by using a template function with a functor template argument to reduce Infer overhead
EgorDuplensky
force-pushed
the
infer_update_strategy
branch
from
a5ce151 to
631d956
Compare
Contributor
Author
|
@maxnick Could you please take a look |
maxnick
reviewed
Jul 9, 2024
Comment on lines
+1449
to
+1462
| DEBUG_LOG("Infer graph: ", GetName(), ". Status: ", static_cast<int>(status)); | ||
|
|
||
| switch (status) { | ||
| case Status::ReadyDynamic: | ||
| InferDynamic(request, UpdateNodes(m_executableGraphNodes)); | ||
| break; | ||
| case Status::ReadyDynamicSeq: | ||
| InferDynamic(request, UpdateNodesSeq(m_executableGraphNodes)); | ||
| break; | ||
| case Status::ReadyStatic: | ||
| InferStatic(request); | ||
| } else { | ||
| OPENVINO_THROW("Unknown ov::intel_cpu::Graph state: " , static_cast<size_t>(status)); | ||
| break; | ||
| default: | ||
| OPENVINO_ASSERT(IsReady(), "Wrong state of the ov::intel_cpu::Graph. Topology is not ready: ", static_cast<int>(status)); |
Contributor
There was a problem hiding this comment.
We can even drop this branch simply assigning a corresponding function pointer at the compilation stage, it will allow us keep the status enumeration simpler.
Contributor
Author
There was a problem hiding this comment.
Yes, this is the option I have also considered
As well as using an interface with multiple implementations.
But I think switch case is even more clean, explicit, lightweight and straightforward here and do not require strict alignment of infer strategies semantics.
If the list of the infer strategies grows big, we can try to replace it with a function pointer.
maxnick
approved these changes
Jul 10, 2024
dmitry-gorokhov
approved these changes
Jul 11, 2024
spran180
pushed a commit
to spran180/openvino
that referenced
this pull request
Jul 27, 2024
by using a template function with a functor template argument to reduce Infer overhead ### Tickets: - *ticket-id*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using a template function with a functor template argument
to reduce Infer overhead
Tickets: