[CUDA] Renamed CUDAPlugin to NVIDIAPlugin #405
Conversation
|
|
||
| /** | ||
| * @brief Defines the number of throutput streams used by CUDA plugin. | ||
| * @brief Defines the number of throutput streams used by NVIDIA GPU plugin. |
There was a problem hiding this comment.
should we rename the folder with plugin and all files as well?
There was a problem hiding this comment.
It is the draft PR, it is not yet ready for review that is why I added [WIP].
Yes, the folder will be renamed too
There was a problem hiding this comment.
@ilya-lavrenov Lets me clarify something, what do you mean by renaming also files ?
Do you mean about renaming files with prefix cuda_* ?
There was a problem hiding this comment.
Do we need to make CI green first?
There was a problem hiding this comment.
@ilya-lavrenov Yes, but we need to merge first PR in openvino. Because these PRs have cross-dependecies we need to figured out the order of merge. Please, see openvinotoolkit/openvino#12719
lohika-denis-kotov
force-pushed
the
refactoring/rename-cuda_plugin-to-nvidia_gpu
branch
from
9788bfb to
6ab0805
Compare
lohika-denis-kotov
changed the title
lohika-denis-kotov
force-pushed
the
refactoring/rename-cuda_plugin-to-nvidia_gpu
branch
from
6ab0805 to
fb9d75a
Compare
lohika-denis-kotov
changed the title
lohika-denis-kotov
force-pushed
the
refactoring/rename-cuda_plugin-to-nvidia_gpu
branch
from
ead3930 to
7bcb0a8
Compare
lohika-denis-kotov
force-pushed
the
refactoring/rename-cuda_plugin-to-nvidia_gpu
branch
6 times, most recently
from
463db81 to
d8859b5
Compare
lohika-denis-kotov
force-pushed
the
refactoring/rename-cuda_plugin-to-nvidia_gpu
branch
from
d8859b5 to
ab9b1f1
Compare
|
@lohika-denis-kotov please, remove useless changes on OV and make CI green here if needed |
@ilya-lavrenov I thought that you will wait till I remove extra commit in history and also CI will be passed. Why did you merged it without green CI ? |
3 participants
I suggest to leave all commits, because in this PR lots of files was renamed. All renaming changes done in separate commits, that is why you can see that these is not new files. If all commits would be squashed in one, then in history it probably will shown that old files was removed and new files was added and it makes harder to search why some changes was done using
git blameThis PR depends on openvinotoolkit/openvino#12719