-
Notifications
You must be signed in to change notification settings - Fork 56
[docs] RV32IM Extension specs #1404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
manh9203
commented
Mar 10, 2025
•
edited
Loading
edited
- Added more detailed code comments for the circuit implementation
- Removed unnecessary constraints
- Added a README describing the statements each circuit must prove. Although it doesn’t prove circuit soundness by itself, it outlines the goal to be met when the circuit is modified.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@manh9203 can you separate this PR so that this one contains only doc/specs and no circuit changes? |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, both markdown and code comments help a lot!
Some comments on wording improvements. In the core chip descriptions, please also include the assumptions on the input (mostly whether things should have been range checked already).
Commit: 3b42a87 |