Skip to content

[docs] RV32IM Extension specs #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 12, 2025
Merged

[docs] RV32IM Extension specs #1404

merged 11 commits into from
Mar 12, 2025

Conversation

manh9203
Copy link
Contributor

@manh9203 manh9203 commented Mar 10, 2025

  • Added more detailed code comments for the circuit implementation
  • Removed unnecessary constraints
  • Added a README describing the statements each circuit must prove. Although it doesn’t prove circuit soundness by itself, it outlines the goal to be met when the circuit is modified.

@manh9203 manh9203 marked this pull request as draft March 10, 2025 19:07

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@manh9203 manh9203 marked this pull request as ready for review March 10, 2025 23:25
@manh9203 manh9203 requested a review from jonathanpwang March 10, 2025 23:25

This comment has been minimized.

@jonathanpwang
Copy link
Contributor

@manh9203 can you separate this PR so that this one contains only doc/specs and no circuit changes?
It's best that all circuit changes are done in a standalone PR so it's easier to review and see the diffs.

This comment has been minimized.

Copy link
Contributor

@jonathanpwang jonathanpwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both markdown and code comments help a lot!

Some comments on wording improvements. In the core chip descriptions, please also include the assumptions on the input (mostly whether things should have been range checked already).

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+24 [+1.7%]) 1,396 147,020 8,194,664 - - -
fibonacci_program (+13 [+0.3%]) 4,960 1,500,096 51,485,167 - - -
regex_program 13,977 4,140,164 167,389,450 - - -
ecrecover_program (-35 [-1.4%]) 2,487 295,181 15,586,346 - - -

Commit: 3b42a87

Benchmark Workflow

@manh9203 manh9203 merged commit b0ef817 into main Mar 12, 2025
16 checks passed
@manh9203 manh9203 deleted the docs/rv32im-specs branch March 12, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants