Skip to content

[fix] Native ASM compiler checks stack overflow #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

nyunyunyunyu
Copy link
Contributor

@nyunyunyunyu nyunyunyunyu commented Mar 11, 2025

All frame pointers are known at compile time. So we can check stack overflow at compile time.

Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+17 [+1.2%]) 1,406 147,020 8,194,664 - - -
fibonacci_program (-50 [-1.0%]) 4,996 1,500,096 51,485,167 - - -
regex_program (-44 [-0.3%]) 13,930 4,140,164 167,389,450 - - -
ecrecover_program (+11 [+0.4%]) 2,551 295,181 15,586,346 - - -

Commit: a560583

Benchmark Workflow

Copy link
Contributor

@zlangley zlangley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

vercel bot commented Mar 11, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@nyunyunyunyu nyunyunyunyu merged commit b02c1bd into main Mar 12, 2025
19 of 20 checks passed
@nyunyunyunyu nyunyunyunyu deleted the fix/native-compile-stack-of branch March 12, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants