Skip to content

refactor: Rename root_is_on_right to sibling_is_on_right for clarity #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

zlangley
Copy link
Contributor

@zlangley zlangley commented Mar 12, 2025

Renames the variable root_is_on_right to sibling_is_on_right throughout the codebase to better reflect its meaning. The field represents whether the sibling in the Merkle tree is on the right, not the root.

This change updates the variable `root_is_on_right` to `sibling_is_on_right` throughout
the codebase to better reflect its meaning. The field represents whether the Merkle proof
sibling is on the right, not the root.
@zlangley zlangley requested a review from jonathanpwang March 12, 2025 14:17
Copy link

group app.proof_time_ms app.cycles app.cells_used leaf.proof_time_ms leaf.cycles leaf.cells_used
verify_fibair (+22 [+1.6%]) 1,410 147,020 8,194,664 - - -
fibonacci_program (+49 [+1.0%]) 5,017 1,500,096 51,485,167 - - -
regex_program (-65 [-0.5%]) 13,826 4,140,164 167,389,450 - - -
ecrecover_program (+62 [+2.5%]) 2,558 295,181 15,586,346 - - -

Commit: 958d937

Benchmark Workflow

Copy link

vercel bot commented Mar 12, 2025

Deployment failed with the following error:

Creating the Deployment Timed Out.

@jonathanpwang jonathanpwang merged commit 9f360e5 into main Mar 12, 2025
18 of 19 checks passed
@jonathanpwang jonathanpwang deleted the refactor/rename-root-is-on-right branch March 12, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants