fix: ECDSA verify should not panic when signature not reduced #1458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding by @lispc
Description of Fix
IntMod::assert_unique
toIntMod::assert_reduced
and move the implementation usingiseqmod
into macro since it's specific to the use of special intrinsic.is_reduced() -> bool
that checks if an integer representation is less than the modulus. Does simple byte-wise comparison check.r
ors
are not in[1,n]
.Closes INT-3517